From 01b112a031a2f0c6390e541bbaaeb8e0d85c9e0b Mon Sep 17 00:00:00 2001 From: cjihrig Date: Fri, 21 Dec 2018 13:50:04 -0500 Subject: [PATCH] test: update postmortem metadata test for V8 7.3 The V8 7.3 update requires the following adjustments to the postmortem debugging metadata constants: - v8dbg_prop_idx_first was removed in https://github.com/v8/v8/commit/1ad0cd560eb8c35bbc7bda49968af1f3859425fe - v8dbg_jsarray_buffer_was_neutered_mask was renamed to v8dbg_jsarray_buffer_was_detached_mask in https://github.com/v8/v8/commit/f68ee6e7e49ac33b3ba870f7287555c5dae9051e - v8dbg_jsarray_buffer_was_neutered_shift was renamed to v8dbg_jsarray_buffer_was_detached_shift in https://github.com/v8/v8/commit/f68ee6e7e49ac33b3ba870f7287555c5dae9051e - v8dbg_class_Map__instance_descriptors__DescriptorArray moved to v8dbg_class_Map__raw_instance_descriptors__DescriptorArray and began using ACCESSORS2 in https://github.com/v8/v8/commit/799dfad502839b6e648741770d9dcd4f9be9e834 The following postmortem debugging constants were also impacted by V8's introduction of ACCESSORS2, but do not need to be updated the test: - v8dbg_class_ThinString__actual__String changed in https://github.com/v8/v8/commit/0f581e4b99ee923e7ebae72e64ee58999ff74b5d - v8dbg_class_UncompiledData__inferred_name__String changed in https://github.com/v8/v8/commit/0f581e4b99ee923e7ebae72e64ee58999ff74b5d - v8dbg_class_JSFunction__shared__SharedFunctionInfo changed in https://github.com/v8/v8/commit/81620900e93bf9d2c5c84346b29c0f9ec7d7b28d - v8dbg_class_SharedFunctionInfo__function_data__Object had its accessor removed in https://github.com/v8/v8/commit/a55803a15d2b202562d72bb186463ca3ebef0c1c This has been fixed in gen-postmortem-metadata.py. PR-URL: https://github.com/nodejs/node/pull/25852 Reviewed-By: Ujjwal Sharma Reviewed-By: Matteo Collina Reviewed-By: Ali Ijaz Sheikh --- test/v8-updates/test-postmortem-metadata.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index bbe74c7d6fd0a1..81fc21aa6a10bb 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -84,7 +84,7 @@ function getExpectedSymbols() { 'v8dbg_class_Map__constructor_or_backpointer__Object', 'v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char', 'v8dbg_class_Map__instance_type__uint16_t', - 'v8dbg_class_Map__instance_descriptors__DescriptorArray', + 'v8dbg_class_Map__raw_instance_descriptors__DescriptorArray', 'v8dbg_class_Map__instance_size_in_words__char', 'v8dbg_class_Oddball__kind_offset__int', 'v8dbg_class_Script__line_ends__Object', @@ -116,8 +116,8 @@ function getExpectedSymbols() { 'v8dbg_frametype_InternalFrame', 'v8dbg_frametype_OptimizedFrame', 'v8dbg_frametype_StubFrame', - 'v8dbg_jsarray_buffer_was_neutered_mask', - 'v8dbg_jsarray_buffer_was_neutered_shift', + 'v8dbg_jsarray_buffer_was_detached_mask', + 'v8dbg_jsarray_buffer_was_detached_shift', 'v8dbg_namedictionary_prefix_start_index', 'v8dbg_namedictionaryshape_entry_size', 'v8dbg_namedictionaryshape_prefix_size', @@ -134,7 +134,6 @@ function getExpectedSymbols() { 'v8dbg_prop_desc_key', 'v8dbg_prop_desc_size', 'v8dbg_prop_desc_value', - 'v8dbg_prop_idx_first', 'v8dbg_prop_index_mask', 'v8dbg_prop_index_shift', 'v8dbg_prop_kind_mask',