From 017b99a8813473a465fb25d186a7acb7e6785b66 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 13 Jan 2019 20:35:52 -0800 Subject: [PATCH] test: refactor pummel/test-net-connect-econnrefused * Reduce ROUNDS and ATTEMPTS_PER_ROUND by half to avoid spurious test failures as a result of side effects from other tests. (For my local setup, test-keep-alive seems to cause this test to fail with ETIMEDOUT and/or EADDRNOTAVAIL. It would seem to be a result of throttling. Reducing the pummel-iness of that test and this one seems to solve the problem.) * Apply capitalization and punctuation to comment. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater --- test/pummel/test-net-connect-econnrefused.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/pummel/test-net-connect-econnrefused.js b/test/pummel/test-net-connect-econnrefused.js index 0f350bd572f177..39737f73bf0831 100644 --- a/test/pummel/test-net-connect-econnrefused.js +++ b/test/pummel/test-net-connect-econnrefused.js @@ -20,14 +20,14 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -// verify that connect reqs are properly cleaned up +// Verify that connect reqs are properly cleaned up. const common = require('../common'); const assert = require('assert'); const net = require('net'); -const ROUNDS = 10; -const ATTEMPTS_PER_ROUND = 100; +const ROUNDS = 5; +const ATTEMPTS_PER_ROUND = 50; let rounds = 1; let reqs = 0;