Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review state of canary in CI #244

Closed
targos opened this issue Nov 20, 2022 · 24 comments
Closed

Review state of canary in CI #244

targos opened this issue Nov 20, 2022 · 24 comments
Assignees
@targos

Comments

@targos
Copy link
Member

targos commented Nov 20, 2022

Previous thread: #234
@targos targos pinned this issue Nov 20, 2022
@targos
Copy link
Member Author

targos commented Nov 20, 2022

Commit: 61c569b
CI: https://ci.nodejs.org/job/node-test-commit/58038/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4999/

@targos targos self-assigned this Nov 20, 2022
@targos
Copy link
Member Author

targos commented Nov 30, 2022

Commit: d0f8aa5
CI: https://ci.nodejs.org/job/node-test-commit/58269/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5024/

@targos

This comment was marked as resolved.

Sign in to view
@targos
Copy link
Member Author

targos commented Dec 12, 2022

Commit: f3518f1
CI: https://ci.nodejs.org/job/node-test-commit/58470/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5050/

@targos

This comment was marked as resolved.

Sign in to view
@targos
Copy link
Member Author

targos commented Dec 14, 2022

Commit: 55078b9
CI: https://ci.nodejs.org/job/node-test-commit/58531/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5057/

@targos targos mentioned this issue Dec 14, 2022
Closed
@targos
Copy link
Member Author

targos commented Dec 28, 2022

Commit: 1e9e12a
CI: https://ci.nodejs.org/job/node-test-commit/58839/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5076/

@targos
Copy link
Member Author

targos commented Jan 2, 2023

Commit: ab4a9fc
CI: https://ci.nodejs.org/job/node-test-commit/58912/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5089/

@targos

This comment was marked as outdated.

Sign in to view
@targos
Copy link
Member Author

targos commented Jan 24, 2023

Commit: 9c511d8
CI: https://ci.nodejs.org/job/node-test-commit/59307/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5135/

@richardlau
Copy link
Member

richardlau commented Jan 24, 2023 •
edited
Loading

Commit: 9c511d8
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5135/

@miladfarca informed me just yesterday about https://chromium-review.googlesource.com/c/v8/v8/+/4181030 requiring Python 3.8, which is the issue for the ImportErrors on ppc64le and s390x:

11:37:54 	/usr/bin/python3.6 deps/v8/tools/run-tests.py --gn --arch=ppc64 --progress=dots --timeout=120 intl \
11:37:54 			mjsunit cctest debugger inspector message preparser \
11:37:54 			--json-test-results /home/iojs/build/workspace/node-test-commit-v8-linux/v8-tap.json --slow-tests-cutoff 1000000
11:37:54 Traceback (most recent call last):
11:37:56   File "deps/v8/tools/run-tests.py", line 11, in <module>
11:37:56     from testrunner import standard_runner
11:37:56   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/standard_runner.py", line 23, in <module>
11:37:56     import testrunner.base_runner as base_runner
11:37:56   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/base_runner.py", line 26, in <module>
11:37:56     from testrunner.utils.augmented_options import AugmentedOptions
11:37:56   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/testrunner/utils/augmented_options.py", line 9, in <module>
11:37:56     from functools import cached_property
11:37:56 ImportError: cannot import name 'cached_property'

@targos
Copy link
Member Author

targos commented Jan 24, 2023 •
edited
Loading

Compiler error on x86 Windows:

11:34:08 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(345,35): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_compiler.vcxproj]
11:34:08 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(346,28): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_compiler.vcxproj]
11:34:08 C:\workspace\node-compile-windows\node\deps\v8\src\heap\large-spaces.h(60,33): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_compiler.vcxproj]

Edit:

According to release CI, this appeared with V8 11.1.180. Previous successful build was done with V8 11.1.155.
Diff: v8/v8@11.1.155...11.1.180

Failing asserts:

In src/heap/spaces.h:

static_assert(sizeof(MemoryChunk) <= MemoryChunk::kHeaderSize);
static_assert(sizeof(Page) <= MemoryChunk::kHeaderSize);

In src/heap/large-spaces.h:

static_assert(sizeof(LargePage) <= MemoryChunk::kHeaderSize);

@targos
Copy link
Member Author

targos commented Jan 24, 2023

I don't know what can explain the apparition of this error but I'll try to revert v8/v8@92a7385 as it's touching the memory chunk layout and is specific to 32bit msvc.

@targos
Copy link
Member Author

targos commented Jan 24, 2023 •
edited
Loading

Trying targos/node@6740c1c

https://ci.nodejs.org/job/node-test-commit-windows-fanned/52766/
ARM build for good measure: https://ci.nodejs.org/job/node-test-commit-windows-arm/6/

Edit: Looks like a red herring. It failed with the same error.

@targos
Copy link
Member Author

targos commented Jan 24, 2023

/cc @nodejs/platform-windows

@targos
Copy link
Member Author

targos commented Jan 24, 2023 •
edited
Loading

I bisected V8 versions using CI. Down to this diff: v8/v8@11.1.176...11.1.177

@targos
Copy link
Member Author

targos commented Jan 24, 2023

If my analysis is right, there's only one change between 11.1.176 and 11.1.177: https://chromium-review.googlesource.com/c/v8/v8/+/4138254

@targos
Copy link
Member Author

targos commented Jan 28, 2023

@richardlau Is it going to be difficult to update?

#244 (comment)

@richardlau
Copy link
Member

@richardlau Is it going to be difficult to update?

#244 (comment)

I don't think so, I just haven't had time to look at it yet. RHEL 8 does have packages for newer versions of Python although we may need other Ansible tweaks to make sure the builds use the newer Python as the system Python 3 will be 3.6.

@richardlau richardlau mentioned this issue Jan 30, 2023
Merged
@richardlau
Copy link
Member

@richardlau Is it going to be difficult to update?
#244 (comment)

I don't think so, I just haven't had time to look at it yet. RHEL 8 does have packages for newer versions of Python although we may need other Ansible tweaks to make sure the builds use the newer Python as the system Python 3 will be 3.6.

We did indeed need additional Ansible tweaks (use of alternatives). PR for our Ansible scripts: nodejs/build#3163

@targos
Copy link
Member Author

targos commented Jan 31, 2023

Commit: 46715db
CI: https://ci.nodejs.org/job/node-test-commit/59465/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5149/

@targos targos mentioned this issue Feb 1, 2023
Closed
richardlau added a commit to nodejs/build that referenced this issue Feb 3, 2023
@richardlau
ansible: update V8 builders to Python 3.9 (#3163)
f0042c2 
Recent upstream V8 changes now require at least Python 3.8 to run
the V8 test runner.

Refs: nodejs/node-v8#244 (comment)
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4181030
@targos
Copy link
Member Author

targos commented Feb 5, 2023

Commit: 0c46dc8
CI: https://ci.nodejs.org/job/node-test-commit/59593/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5162/

@targos
Copy link
Member Author

targos commented Feb 5, 2023

Windows arm64 build is broken:

10:39:16   simulator-arm64.cc
10:39:16 C:\workspace\node-compile-windows\node\deps\v8\src\trap-handler\trap-handler-simulator.h(38,5): error C2143: syntax error: missing ';' before 'asm' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler_host.vcxproj]
10:39:16 C:\workspace\node-compile-windows\node\deps\v8\src\trap-handler\trap-handler-simulator.h(38,44): error C2290: C++ 'asm' syntax ignored. Use __asm. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler_host.vcxproj]
10:39:16   handler-outside-simulator.cc
10:39:16 C:\workspace\node-compile-windows\node\deps\v8\src\trap-handler\trap-handler-simulator.h(38,5): error C2143: syntax error: missing ';' before 'asm' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler_host.vcxproj]
10:39:16 C:\workspace\node-compile-windows\node\deps\v8\src\trap-handler\trap-handler-simulator.h(38,44): error C2290: C++ 'asm' syntax ignored. Use __asm. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler_host.vcxproj]

It's due to this change: v8/v8@a696609

@nodejs/platform-windows-arm

@targos
Copy link
Member Author

targos commented Feb 18, 2023

Commit: ae56081
CI: https://ci.nodejs.org/job/node-test-commit/59920/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5182/

@targos targos closed this as completed Apr 17, 2023
@targos targos mentioned this issue Apr 17, 2023
Closed
@targos targos unpinned this issue Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@targos targos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @richardlau