Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue with inspector protocol #217

Closed
targos opened this issue Jan 18, 2022 · 4 comments
Closed

Build issue with inspector protocol #217

targos opened this issue Jan 18, 2022 · 4 comments

Comments

@targos
Copy link
Member

targos commented Jan 18, 2022

https://github.com/nodejs/node-v8/runs/4849367189?check_suite_focus=true

  ACTION Generating inspector protocol sources from protocol json d23d8a137c8fbb57971473ca20bd47e375edd81c.intermediate
  CXX(target) /home/runner/work/node-v8/node-v8/node-v8/out/Release/obj.target/v8_libplatform/deps/v8/src/libplatform/default-foreground-task-runner.o
Traceback (most recent call last):
  File "../../deps/v8/third_party/inspector_protocol/code_generator.py", line 702, in <module>
    main()
  File "../../deps/v8/third_party/inspector_protocol/code_generator.py", line 572, in main
    protocol = Protocol(config)
  File "../../deps/v8/third_party/inspector_protocol/code_generator.py", line 360, in __init__
    self.generate_domains = self.read_protocol_file(config.protocol.path)
AttributeError: 'X' object has no attribute 'path'
make[1]: *** [tools/v8_gypfiles/v8_base_without_compiler.target.mk:30: d23d8a137c8fbb57971473ca20bd47e375edd81c.intermediate] Error 1

It seems that the path property is added from the build file: https://chromium.googlesource.com/v8/v8.git/+/refs/heads/main/src/inspector/BUILD.gn#51

Introduced in https://chromium.googlesource.com/v8/v8.git/+/db77f7fb4acbc7d75fbacbcaed8ded4e36be457f

@vsemozhetbyt
Copy link

Is this the cause of no canary binaries since 10-Jan-2022?

@targos
Copy link
Member Author

targos commented Jan 29, 2022

Is this the cause of no canary binaries since 10-Jan-2022?

Probably.

@targos
Copy link
Member Author

targos commented Feb 24, 2022

I don't know how to handle this correctly on our side, so I'm going to float a patch that adds the field back to inspector_protocol_config.json.

@targos
Copy link
Member Author

targos commented Feb 24, 2022

Actually, I found the solution in the Bazel file 🎉
This can easily be done similarly in inspector.gypi: nodejs/node@bcec01e

@targos targos closed this as completed Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants