From 691f1c465d74ad6ae7a253fab74af7af98e5611e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Wed, 21 Sep 2022 15:47:37 +0200 Subject: [PATCH] deps: always define V8_EXPORT_PRIVATE as no-op dllexport introduces issues when compiling with MSVC. --- common.gypi | 2 +- deps/v8/src/base/macros.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/common.gypi b/common.gypi index 3f56b18b318..42a76de6ca3 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.3', + 'v8_embedder_string': '-node.4', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/base/macros.h b/deps/v8/src/base/macros.h index cd5b91f745a..c267b8f1e9f 100644 --- a/deps/v8/src/base/macros.h +++ b/deps/v8/src/base/macros.h @@ -389,9 +389,9 @@ bool is_inbounds(float_t v) { // Setup for Windows shared library export. #ifdef BUILDING_V8_SHARED -#define V8_EXPORT_PRIVATE __declspec(dllexport) +#define V8_EXPORT_PRIVATE #elif USING_V8_SHARED -#define V8_EXPORT_PRIVATE __declspec(dllimport) +#define V8_EXPORT_PRIVATE #else #define V8_EXPORT_PRIVATE #endif // BUILDING_V8_SHARED @@ -401,7 +401,7 @@ bool is_inbounds(float_t v) { // Setup for Linux shared library export. #if V8_HAS_ATTRIBUTE_VISIBILITY #ifdef BUILDING_V8_SHARED -#define V8_EXPORT_PRIVATE __attribute__((visibility("default"))) +#define V8_EXPORT_PRIVATE #else #define V8_EXPORT_PRIVATE #endif