Skip to content

Commit

Permalink
deps: always define V8_EXPORT_PRIVATE as no-op
Browse files Browse the repository at this point in the history
dllexport introduces issues when compiling with MSVC.
  • Loading branch information
targos authored and nodejs-github-bot committed Jan 2, 2023
1 parent d4b7224 commit 691f1c4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.3',
'v8_embedder_string': '-node.4',

##### V8 defaults for Node.js #####

Expand Down
6 changes: 3 additions & 3 deletions deps/v8/src/base/macros.h
Original file line number Diff line number Diff line change
Expand Up @@ -389,9 +389,9 @@ bool is_inbounds(float_t v) {

// Setup for Windows shared library export.
#ifdef BUILDING_V8_SHARED
#define V8_EXPORT_PRIVATE __declspec(dllexport)
#define V8_EXPORT_PRIVATE
#elif USING_V8_SHARED
#define V8_EXPORT_PRIVATE __declspec(dllimport)
#define V8_EXPORT_PRIVATE
#else
#define V8_EXPORT_PRIVATE
#endif // BUILDING_V8_SHARED
Expand All @@ -401,7 +401,7 @@ bool is_inbounds(float_t v) {
// Setup for Linux shared library export.
#if V8_HAS_ATTRIBUTE_VISIBILITY
#ifdef BUILDING_V8_SHARED
#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
#define V8_EXPORT_PRIVATE
#else
#define V8_EXPORT_PRIVATE
#endif
Expand Down

0 comments on commit 691f1c4

Please sign in to comment.