This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
querystring: do not display separator for empty array stringify #7975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| var keys = Object.keys(obj); | ||
| var fields = []; | ||
|
|
||
| for (var i = 0, il = keys.length; i < il; ++i) { |
There was a problem hiding this comment.
Do not cache keys.length, there is no point in it.
Currently, stringification of an empty array outputs a single separator character. This commit causes an empty array to output the empty string.
|
@indutny I have made the requested changes. I added two additional tests to protect against regressions where the object is As for not caching the array length in the loop - I've heard of that as good practice. Is your reason for leaving it out because V8 is smart enough to cache the value on its own? |
|
@cjihrig yes. This practice is no longer relevant AFAIK, btw. |
|
Landed in 61ddad1, thank you! |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, stringification of an empty array outputs a single separator character. This commit causes an empty array to output the empty string. Also removed an unnecessary
ifstatement. Related to #7971