add support for SPF records to DNS resolver #7699
Conversation
|
Your pull request is made against master but it looks like v0.10 code and new features don't usually get accepted into the stable branch (i.e. v0.10). I would recommend updating your code so it compiles with V8 3.25. Another thing is the commit log, it doesn't adhere to the style guide. See CONTRIBUTING.md for an example. |
|
@jons sorry, but as @bnoordhuis said, landing new features in v0.10 branch is against our policy. Would you mind rebasing it onto a master branch? |
|
i didn't bother with setting the upstream track, but CONTRIBUTING.md demonstrates using "-t origin/v0.10" -- is this correct? i'll fix the commit log. i assume the correct subsystem name is "dns" ? i was not offering a backport i was simply stating that i had tested it there, not master (but i will test it in master AND add/modify any existing unit tests for the next pull request). |
|
i've also just learned that rfc 4408 was accepted to the standards track last month as 7208 so it wasn't even named correctly :) |
|
closing this request to create a new one. |
.eslintrc was renamed in nodejs#7699 to .eslintrc.yaml. PR-URL: nodejs/node#12116 Refs: nodejs/node#7699 Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
.eslintrc was renamed in nodejs#7699 to .eslintrc.yaml. PR-URL: nodejs/node#12116 Refs: nodejs/node#7699 Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
tested on v0.10.28 release. see: https://tools.ietf.org/html/rfc4408#section-3.1.1