This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Throw if fs start arg is not number #2780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1038,8 +1038,13 @@ var ReadStream = fs.ReadStream = function(path, options) { | |||
| if (this.encoding) this.setEncoding(this.encoding); | |||
|
|
|||
| if (this.start !== undefined) { | |||
| if ('number' !== typeof this.start) { | |||
| throw TypeError("'start' must be a Number or left undefined, not a string containing a number"); | |||
There was a problem hiding this comment.
Minor beans, but I think the "left" should be removed (sounds a little better IMO), as well as "not a string containing a number" (you're not sure that this is the case, what if it's an Object of some sort?)
|
I'm not sure if this is something we care about but this would break for anyone passing around a |
|
I agree with @TooTallNate. Message should just be Passing around Otherwise LGTM. |
|
Landed on 7f58d20. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing issues #2554 and #2567