This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: make release process usable by multiple users #25638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misterdjules
force-pushed
the
multi-user-release-process
branch
from
ea67361
to
2369189
Compare
|
I haven't run this, but the change LGTM. I'll give it a run next week. |
|
LGTM too from a glance |
misterdjules
pushed a commit
that referenced
this pull request
Jul 16, 2015
Use staging area on nodejs.org instead of TJ's account. Also pushes release tag and branch to personal forks rather than joyent/node, which makes errors have less impact. Pushing release tags and branches is left as a manual step for the release managers, when they decide the timing is best. PR: #25638 PR-URL: #25638 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in ec861f6, thank you @sam-github and @cjihrig 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step in making the release process easier to use by multiple users.
Instead of using
/home/tjonnodejs.orgas a staging directory, it uses/home/staging, which we also can control access to via ssh keys.Instead of pushing tags and branches directly to joyent/node, it pushes them to the personal fork of the person doing the release, so there's a chance to fix errors and mistakes before pushing tags and releases branches to the reference repository.
Finally it also now distinguishes between stable, maintenance and unstable versions to mirror the current v0.10/v0.12/v0.13 release lines.
These changes are in sync with the latest changes I made recently to the nodejs-release Jenkins job and Node.js release guide.
/cc @joyent/node-collaborators