High-level debugger API #1667
High-level debugger API #1667
Conversation
|
I'm going to refactor some parts of written code, feel free to criticize any naming mistakes or anything related to code style. |
|
This is looking very nice. |
|
There is problem with getters and vm.ScriptContext, that causes segfaults. So I emulated getters by automatically invoking internal functions. |
|
Ok, so I figured out what happens when we use getters in Context. In this loop https://github.com/joyent/node/blob/master/src/node_script.cc#L348-353 we're getting all properties' values. Calling |
|
One more problem: Try downloading https://gist.github.com/1202987 and running |
|
Getters/Setters problem fixed in #1673 |
Started porting to high-level javascript API and repl.
Add async completion and execution interface for repl and readline
Move commands closer to each other, use .debugEval and .controlEval for controlling repl output (no more incorrect 'debug>' prints).
…akpoint message and do not output explicit debug> on breaks
…r position after repl autocompletion, small refactor in readline
Lift prototype methods not only as accessors, but as properties too. this.print() supports javascript objects inspection this.error() implemented, don't throw error at callbacks and commands Fixed list() invokation, when script is not on a breakpoint Removed obsolete process.nextTick from `step` commands
|
Star this bug: http://code.google.com/p/v8/issues/detail?id=1639 Looks like it's the reason of |
…ebug repl (when not on breakpoint)
|
very cool - thank you. we'll take incremental updates from here.
|
|
Priorities:
|
|
Tested debugger on windows - it works as fine as it works on linux. |
This is in-progress pull request. I opened it to get a feedback from you about new API.
Changes:
replinstead of rawreadlinereplandreadlinerepl()opens async repl that runs in script that is being debugged