Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

test-vm-timeout failures on ubuntu 10 in 0.12.X #9317

Closed
mhdawson opened this issue Mar 2, 2015 · 5 comments
Closed

test-vm-timeout failures on ubuntu 10 in 0.12.X #9317

mhdawson opened this issue Mar 2, 2015 · 5 comments
Milestone

Comments

@mhdawson
Copy link
Member

mhdawson commented Mar 2, 2015

As part of our internal 0.12.0 node testing we see intermittent failures of the test-vm-timeout test. It fails in 1 in 5 or more runs.

We only see the failures on ubuntu 10 at this point, but I've not run lots of repeats to see if we can recreate on other OS versions.

In any case, I found this issue in io.js nodejs/node#622 and it matches the problem that I'm seeing and I validated that it resolves the failure. The explanation also explains why we'd only see it on ubuntu 10, the issue is related to timer precision on older kernels.

Seems like we should pull this patch over.

@jasnell
Copy link
Member

jasnell commented Mar 3, 2015

+1

1 similar comment
@orangemocha
Copy link
Contributor

+1

@misterdjules
Copy link

It makes sense to me too, thank you @mdawsonibm! Do you want to take care of porting nodejs/node#622?

@mhdawson mhdawson added this to the 0.12.1 milestone Mar 12, 2015
@mhdawson
Copy link
Member Author

Pull request created #9410

@mhdawson
Copy link
Member Author

Landed in 7e9d2f8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants