You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Currently, http.request uses the path property of the options object. url.parse returns objects with a path property, so http.request and url.parse work well together. However, url.format doesn't use the path property of its input object.
url.format and http.request should interpret url objects the same way. Users should also still have the ability to change the parsed url objects and have http.request and url.format behave intuitively.
The text was updated successfully, but these errors were encountered:
Currently,
http.request
uses thepath
property of theoptions
object.url.parse
returns objects with apath
property, sohttp.request
andurl.parse
work well together. However,url.format
doesn't use thepath
property of its input object.This leads to confusion from users like #8722. An attempt at fixing this was made with d312b6d, but it broke some existing code that should work intuitively.
Another PR tried to fix the breaking change while still making
url.format
handle thepath
property, but it was decided that it was still making the url.format API confusing and hard to use properly.url.format
andhttp.request
should interpret url objects the same way. Users should also still have the ability to change the parsed url objects and havehttp.request
andurl.format
behave intuitively.The text was updated successfully, but these errors were encountered: