Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Fails to build when '--without-ssl' configure option set #8645

Closed
amudukutore opened this issue Oct 29, 2014 · 5 comments
Closed

Fails to build when '--without-ssl' configure option set #8645

amudukutore opened this issue Oct 29, 2014 · 5 comments

Comments

@amudukutore
Copy link

I see the following error message in the build log:
out/Release/obj.target/node/src/node.o: In function ParseArgs': out/../src/node.cc:2583: undefined reference tonode::SSL2_ENABLE'
out/../src/node.cc:2586: undefined reference to `node::SSL3_ENABLE'
collect2: error: ld returned 1 exit status
gmake[1]: *** [out/Release/node] Error 1

The following patch appears to fix this:
diff --git a/src/node.cc b/src/node.cc
index 18c743f..44026e2 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -2544,8 +2544,10 @@ static void PrintHelp() {
" --trace-deprecation show stack traces on deprecations\n"
" --v8-options print v8 command line options\n"
" --max-stack-size=val set max v8 stack size (bytes)\n"
+#if HAVE_OPENSSL
" --enable-ssl2 enable ssl2\n"
" --enable-ssl3 enable ssl3\n"
+#endif
"\n"
"Environment variables:\n"
#ifdef _WIN32
@@ -2579,12 +2581,14 @@ static void ParseArgs(int argc, char argv) {
p = 1 + strchr(arg, '=');
max_stack_size = atoi(p);
argv[i] = const_cast<char
>("");
+#if HAVE_OPENSSL
} else if (strcmp(arg, "--enable-ssl2") == 0) {
SSL2_ENABLE = true;
argv[i] = const_cast<char
>("");
} else if (strcmp(arg, "--enable-ssl3") == 0) {
SSL3_ENABLE = true;
argv[i] = const_cast<char*>("");
+#endif
} else if (strcmp(arg, "--help") == 0 || strcmp(arg, "-h") == 0) {
PrintHelp();
exit(0);

@iankronquist
Copy link

Cannot reproduce, OS X 10.10.

@OsamaAbbas
Copy link

Same error occurs in Ubuntu 14.04.

@Borchmann
Copy link

Same error on Gentoo when emerging with the disabled ssl flag:
../src/node.cc: In function ‘void node::ParseArgs(int*, const char**, int*, const char***, int*, const char***)’: ../src/node.cc:3007:7: error: ‘SSL2_ENABLE’ was not declared in this scope SSL2_ENABLE = true; ../src/node.cc:3009:7: error: ‘SSL3_ENABLE’ was not declared in this scope SSL3_ENABLE = true;
(net-libs/nodejs-0.12.6::gentoo)

@rvagg
Copy link
Member

rvagg commented Nov 14, 2015

/cc @nodejs/crypto @nodejs/build this seems like something we can and should fix for 0.12, seems like just a missing #ifdef

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Nov 14, 2015
Fix the following build error by putting #if guards around the
variables:

    ../src/node.cc: In function 'void node::ParseArgs(int*,
    const char**, int*, const char***, int*, const char***)':
    ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared
    in this scope
           SSL2_ENABLE = true;
           ^
    ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared
    in this scope
           SSL3_ENABLE = true;

Fixes: nodejs/node-v0.x-archive#8645
@bnoordhuis
Copy link
Member

nodejs/node#3825

jasnell pushed a commit to jasnell/node that referenced this issue Nov 15, 2015
Fix the following build error by putting #if guards around the
variables:

    ../src/node.cc: In function 'void node::ParseArgs(int*,
    const char**, int*, const char***, int*, const char***)':
    ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared
    in this scope
           SSL2_ENABLE = true;
           ^
    ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared
    in this scope
           SSL3_ENABLE = true;

Fixes: nodejs/node-v0.x-archive#8645
PR-URL: nodejs#3825
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
bnoordhuis added a commit to nodejs/node that referenced this issue Nov 15, 2015
Fix the following build error by putting #if guards around the
variables:

    ../src/node.cc: In function 'void node::ParseArgs(int*,
    const char**, int*, const char***, int*, const char***)':
    ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared
    in this scope
           SSL2_ENABLE = true;
           ^
    ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared
    in this scope
           SSL3_ENABLE = true;

Fixes: nodejs/node-v0.x-archive#8645
PR-URL: #3825
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jBarz pushed a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
Fix the following build error by putting #if guards around the
variables:

    ../src/node.cc: In function 'void node::ParseArgs(int*,
    const char**, int*, const char***, int*, const char***)':
    ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared
    in this scope
           SSL2_ENABLE = true;
           ^
    ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared
    in this scope
           SSL3_ENABLE = true;

Fixes: nodejs#8645
PR-URL: nodejs/node#3825
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott closed this as completed Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants