fs.rename returns deceptive error when target path is problematic

[mgenev]

when i try to rename a file and its source path is accurate, but target directory doesn't exist, I get simply ENOENT, rename and it quotes the source path. This made me think for a long time that my source path was problematic when the problem all along was that the target dir doesn't exist and there is no indication in the error of that.

[indutny]

What node.js version are you referring to?

[mgenev]

0.10.26

[tjfontaine]

Can you please provide a reproducible test case?

[cjihrig]

I think this should reproduce the described problem. The error only lists the source file being renamed, even though the target is the problem.

var fs = require('fs');
var assert = require('assert');
var src = 'foo.txt';

fs.writeFileSync(src, 'test');
assert(fs.existsSync(src));
assert(!fs.existsSync('bar'));

fs.rename(src, 'bar/baz.txt', function(error) {
  fs.unlinkSync(src);
  assert(error);
  assert(error.path !== src);
});

[mgenev]

That's exactly correct. It's very easy to reproduce.

[ibash]

This is a dupe of #685 , right?

[mmalecki]

@tjfontaine this should be closed as dupe of ^