Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing spaces in generated info #5

Closed
gibfahn opened this issue Nov 21, 2016 · 0 comments
Closed

Trailing spaces in generated info #5

gibfahn opened this issue Nov 21, 2016 · 0 comments

Comments

@gibfahn
Copy link
Member

gibfahn commented Nov 21, 2016

Not exactly an urgent issue, but the PR-URL and Reviewed-By lines each have a trailing space.

Looking through the code I can't see where they'd have been added.

E.g.

nodejs/node#9645

PR-URL: https://github.com/nodejs/node/pull/9645 

Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
TimothyGu added a commit to TimothyGu/node-review that referenced this issue Jan 29, 2017
@TimothyGu
review: remove extra whitespace
1ffd061 
Fixes: nodejs#5
@TimothyGu TimothyGu mentioned this issue Jan 29, 2017
Merged
TimothyGu added a commit to TimothyGu/node-review that referenced this issue Feb 1, 2017
@TimothyGu
review: remove extra whitespace
7cf8cc1 
Fixes: nodejs#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gibfahn