feat: convert internal classes from util.inherits to classes #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
ce5e741
to
0a3e2e0
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
from
de2c1cd
to
051114e
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
0a3e2e0
to
145e56a
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
from
051114e
to
0501ace
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
2 times, most recently
from
e306967
to
614c26c
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
3 times, most recently
from
56e7357
to
210543a
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
from
210543a
to
179dbdd
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
2 times, most recently
from
e842fd3
to
0a67958
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
2 times, most recently
from
f9c558e
to
1c7552e
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
0a67958
to
472c33b
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
from
1c7552e
to
8531963
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
472c33b
to
32a7787
Compare
BREAKING CHANGE: the `Gyp` class exported is now created using ECMAScript classes and therefore might have small differences to classes that were previously created with `util.inherits`.
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
32a7787
to
faa174b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is stacked on #2924
BREAKING CHANGE: the
Gypclass exported is now created usingECMAScript classes and therefore might have small differences to classes
that were previously created with
util.inherits.