feat!: update engines.node to ^14.17.0 || ^16.13.0 || >=18.0.0
#2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cclauss
approved these changes
Apr 8, 2023
n10000k
approved these changes
Apr 8, 2023
|
Looks like the engines upgrade was not a blocker for #2796 after all! I'll close this one. |
legobeat
added a commit
to legobeat/node-gyp
that referenced
this pull request
May 17, 2023
This reverts commit 02480f6, thereby rolling back dependency make-fetch-happen from ^11.0.3 to ^10.0.3. The upgrade is breaking for node-fetch users as it has transitive dependencies with syntax incompatible with supported Node.js versions. Related: - nodejs#2770 - nodejs#2837 - nodejs#2816 - nodejs#2848 - nodejs#2827 - nodejs#2796
4 tasks
legobeat
added a commit
to legobeat/node-gyp
that referenced
this pull request
Jun 26, 2023
This reverts commit 02480f6, thereby rolling back dependency make-fetch-happen from ^11.0.3 to ^10.0.3. The upgrade is breaking for node-fetch users as it has transitive dependencies with syntax incompatible with supported Node.js versions. Related: - nodejs#2770 - nodejs#2837 - nodejs#2816 - nodejs#2848 - nodejs#2827 - nodejs#2796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2753
Checklist
npm install && npm testpasses 1tests are included(N/A)documentation is changed or added(N/A)Description of change
This PR drops support for node 12 and adds node 18.
The change was taken directly from #2770 (I haven't even modified the commit message 2), but I am breaking it out for convenience of review. The updated engines was listed as a blocker for #2796, so the goal is to unblock that fix.
Footnotes
Footnotes
One test was skipped:
test/test-addon.js ... python console app can't encode non-ascii character.↩I noticed previous PRs tagged engine updates under "deps" rather than "feat", but since no one called it out in the original PR, I didn't change it. ↩