DCO and CoC (updated) #1229
Closed
DCO and CoC (updated) #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jun 12, 2017
CONTRIBUTING.md
Outdated
|
|
||
| Please read the | ||
| [Code of Conduct](https://github.com/nodejs/TSC/blob/master/CODE_OF_CONDUCT.md) | ||
| which explains the minimum behavior expectations for Node.js contributors. |
gibfahn
approved these changes
Jun 12, 2017
|
Where did this text come from? Might be worth including it in the commit message. |
lifted verbatim from https://github.com/nodejs/node/blob/master/CONTRIBUTING.md then `/s/Node.js/node-gyp/`
Ack |
gibfahn
pushed a commit
that referenced
this pull request
Jun 14, 2017
Lifted verbatim from https://github.com/nodejs/node/blob/master/CONTRIBUTING.md then `s/Node.js/node-gyp/`. PR-URL: #1229 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
|
Landed in 2e40fad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated #771
lifted verbatim from
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
then
/s/Node.js/node-gyp/