Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggesting some tweaks to find-python.js on Windows #2614

Open
DeeDeeG opened this issue Feb 16, 2022 · 2 comments
Open

Suggesting some tweaks to find-python.js on Windows #2614

DeeDeeG opened this issue Feb 16, 2022 · 2 comments

Comments

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Feb 16, 2022

Now that a semver major release is being proposed (#2603), I wanted to mention some thoughts I have about the default Python install paths check for Windows.

See: winDefaultLocations and winDefaultLocationsArray in find-python.js.

I have a few suggestions in mind:

  • Add Python 3.10 to the list of Python versions we generate the paths to search at.
    • (See: here, add '310' to the list)
  • Try the py.exe launcher before exhaustively searching all the default install paths used by python.org's installer
    • (See: here and put the pylauncher check before the default locations loop rather than after.)
  • Maybe stop all this default path searching altogether?
    • I have felt "eh" about searching (up to) 20 paths trying to find Python, ever since I introduced it. Although I think it's still more helpful than harmful to search for Python in a bunch of places and maybe not find it, since it's still really fast in my experience. Potentially adding another Python version to make it (up to) 25 paths has me feeling slightly more "eh" about it.

Thoughts?

@cclauss
Copy link
Contributor

cclauss commented Feb 16, 2022

Massive +1 on…

Try the py.exe launcher before exhaustively searching all the default install paths used by python.org's installer

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Feb 22, 2022

Still need to find time to post a PR for this.

I hope this isn't holding up v9 -- I guess it could go in a v10 or v11 just as easily. (I'll let reviewers decide if/when to merge, and advise at what semver level.) Thought I would have time to post a PR sooner. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants