Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: and Refs: tags are pulled from PR description #470

Closed
addaleax opened this issue Aug 10, 2020 · 2 comments · Fixed by #474
Closed

Fixes: and Refs: tags are pulled from PR description #470

addaleax opened this issue Aug 10, 2020 · 2 comments · Fixed by #474
Assignees

Comments

@addaleax
Copy link
Member

git node land seems to think that any Fixes: and Refs: tags it finds apply to all commits in a pull request. That’s unhelpful when there’s multiple commits in a PR, see e.g. nodejs/node#34673. Is this intentional? If no, can we remove it? If yes, can we at least create a way to opt out?

@richardlau
Copy link
Member

It probably was intentional. I kind of like not having Fixes/Refs in the commit metadata until landing otherwise referenced issues/PR's get spammed every time you update/force push rebase etc.

+1 for being optional for multi-commit PRs (maybe with a warning) or with an opt-out flag.

@codebytere
Copy link
Member

+1 for warning and opt-out flag from me too - happy to pop up a PR if that seems like the path forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants