Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-node: git node open to create a new PR/open existing PR #252

Closed
joyeecheung opened this issue Jun 12, 2018 · 5 comments
Closed

git-node: git node open to create a new PR/open existing PR #252

joyeecheung opened this issue Jun 12, 2018 · 5 comments
Labels
feature request New features for node-core-utils git-node

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Jun 12, 2018

Basically what git cl upload and git cl web does for chromium/v8, but in one command.

Rough sketch:

  1. Make sure the user is not on master, proposal, release or staging branches
  2. Create a remote branch in the users' fork (might need to ncu-config that remote) if there isn't one
  3. Push to that remote branch (note that this results in an actual push, we may not want to do that in ncu and only want to prompt the user do that before running git node open --continue)
  4. Open the PR creation URL in the browser, and ask the user to come back to the terminal to fill in the PR id when they finished summiting the PR
  5. Store the association locally in .ncu
  6. When the user run git node open again, open the PR in the browser
  7. Bonus: when the user run git node land from the PR, switch to the master branch, land the PR, prompt the user to push to the remote PR branch first to make the PR status "merged" (purple) before pushing to master

If we are feeling adventurous...

  • In step 4, prompt the user to input the PR message (like what git cl upload does) and create the PR for the user. When the PR is created, do step 5, ask if the user wants to trigger the CI and if they do, trigger a CI, post the CI link in the PR (fancy: do a dropdown list from the CLI, let them choose jobs like the benchmark, citgm, etc.)
@devsnek
Copy link
Member

devsnek commented Jun 12, 2018

maybe git node pr open just for ambiguity?

@joyeecheung joyeecheung added feature request New features for node-core-utils git-node labels Jun 12, 2018
@joyeecheung
Copy link
Member Author

@devsnek Good idea. We can add git node pr set <url> or git node pr get that basically does what git cl issue does.

@joyeecheung
Copy link
Member Author

joyeecheung commented Jun 12, 2018

We should also consider #194 to make sure the commands are somewhat intuitive. The difference is, this command is for PR against master while that one is for PR against staging.

@joyeecheung
Copy link
Member Author

About triggering the CI: maybe it's better if we split that into a separate command

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Aug 16, 2020
@targos targos removed the stale label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New features for node-core-utils git-node
Projects
None yet
Development

No branches or pull requests

3 participants