-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-node: git node open
to create a new PR/open existing PR
#252
Comments
maybe |
@devsnek Good idea. We can add |
We should also consider #194 to make sure the commands are somewhat intuitive. The difference is, this command is for PR against master while that one is for PR against staging. |
About triggering the CI: maybe it's better if we split that into a separate command |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
Basically what
git cl upload
andgit cl web
does for chromium/v8, but in one command.Rough sketch:
ncu-config
that remote) if there isn't onegit node open --continue
).ncu
git node open
again, open the PR in the browsergit node land
from the PR, switch to the master branch, land the PR, prompt the user to push to the remote PR branch first to make the PR status "merged" (purple) before pushing to masterIf we are feeling adventurous...
git cl upload
does) and create the PR for the user. When the PR is created, do step 5, ask if the user wants to trigger the CI and if they do, trigger a CI, post the CI link in the PR (fancy: do a dropdown list from the CLI, let them choose jobs like the benchmark, citgm, etc.)The text was updated successfully, but these errors were encountered: