Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-metadata: undetected CI #170

Closed
vsemozhetbyt opened this issue Feb 10, 2018 · 3 comments
Closed

get-metadata: undetected CI #170

vsemozhetbyt opened this issue Feb 10, 2018 · 3 comments
Labels

Comments

@vsemozhetbyt
Copy link
Contributor

PR: nodejs/node#18683

Command: winpty get-metadata.cmd 18683

Output:
√  Done loading data for nodejs/node/pull/18683
----------------------------------- PR info ------------------------------------
Title      Fixed broken links to Style Guide and CPP Style Guide (#18683)
Author     Justin Lee <[email protected]> (@justin0022)
Branch     justin0022:master -> nodejs:master
Labels     doc, fast-track, ready
Commits    1
 - Fixed broken links to Style Guide and CPP Style Guide
Committers 1
 - Justin Lee <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/18683
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
--------------------------------------------------------------------------------
√  Requested Changes: 0
√  Approvals: 5, 2 from TSC (joyeecheung, cjihrig)
×  No CI runs detected
‼  This PR is being fast-tracked, but awating a CI run

@priyank-p
Copy link
Contributor

priyank-p commented Feb 10, 2018

@vsemozhetbyt thanks for reporting bugs :), let see if i can see whats wrong in limited time i have.

priyank-p added a commit to priyank-p/node-core-utils that referenced this issue Feb 10, 2018
priyank-p added a commit to priyank-p/node-core-utils that referenced this issue Feb 10, 2018
@richardlau
Copy link
Member

Probably because the CI run was https://ci.nodejs.org/job/node-test-commit-light/246/ and node-test-commit-light is not in the map

const CI_TYPES = new Map([
[CITGM, { name: 'CITGM', re: /citgm/ }],
[FULL,
{ name: 'Full',
re: /node-test-pull-request|node-test-commit\// }],
[BENCHMARK, { name: 'Benchmark', re: /benchmark/ }],
[LIBUV, { name: 'libuv', re: /libuv/ }],
[NOINTL, { name: 'No Intl', re: /nointl/ }],
[V8, { name: 'V8', re: /node-test-commit-v8/ }],
[LINTER, { name: 'Linter', re: /node-test-linter/ }]
]);

@priyank-p
Copy link
Contributor

@richardlau yep exactly.

priyank-p added a commit to priyank-p/node-core-utils that referenced this issue Feb 10, 2018
priyank-p added a commit to priyank-p/node-core-utils that referenced this issue Feb 10, 2018
priyank-p added a commit to priyank-p/node-core-utils that referenced this issue Mar 9, 2018
priyank-p added a commit to priyank-p/node-core-utils that referenced this issue Mar 10, 2018
priyank-p added a commit to priyank-p/node-core-utils that referenced this issue Mar 10, 2018
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this issue Nov 2, 2022
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this issue Nov 10, 2022
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this issue Jan 27, 2023
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this issue Jan 27, 2023
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this issue Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants