Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

[Converge] repl: Private Buffer object in lib/* files #21

Closed
jasnell opened this issue May 21, 2015 · 3 comments
Closed

[Converge] repl: Private Buffer object in lib/* files #21

jasnell opened this issue May 21, 2015 · 3 comments

Comments

@jasnell
Copy link
Member

jasnell commented May 21, 2015

See: nodejs/node-v0.x-archive@523929c
/cc @trevnorris

The original commit log says, "Fixes usage of global object 'Buffer' in lib/* files by ensuring that each file does an explicit require('buffer').Buffer. Previously, when running a repl, due to usage of global 'Buffer', any redefinition of Buffer would cause a crash eg var Buffer = {}."

@Fishrock123
Copy link
Contributor

This should be ported to io.js.

@Fishrock123
Copy link
Contributor

The plan is to add linting alongside doing an updated version of this. progress here: nodejs/node#1794

@silverwind
Copy link
Contributor

Landed a ported version in nodejs/node@b5b8ff1, notable difference is that the workaround for the race condition wasn't necessary any more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants