Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Merge nodejs/node master #245

Merged
merged 255 commits into from
May 18, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
255 commits
Select commit Hold shift + click to select a range
e927809
test: dynamic port in parallel regress tests
Apr 26, 2017
5bb06e8
src: remove GTEST_DONT_DEFINE_ASSERT_EQ in util.h
danbev Apr 25, 2017
f6b1eb2
test: use common.js to check platform
krydos Apr 24, 2017
28f535a
test: fixup test-http-hostname-typechecking
addaleax Apr 24, 2017
d289678
test: dynamic port in dgram tests
Apr 24, 2017
78e0063
build: use do_not_edit variable where possible
krydos Apr 23, 2017
2055fd3
test: cleanup test-util-inherits.js
RobotMermaid Apr 22, 2017
dca0815
test: introduce `common.crashOnUnhandledRejection`
addaleax Apr 19, 2017
e5a25cb
src: expose `node::AddPromiseHook`
addaleax Apr 21, 2017
84dabe8
domain: support promises
addaleax Apr 18, 2017
892ce06
src: fix incorrect macro comment
danbev Apr 27, 2017
4271254
n-api: Reference and external tests
jasongin Apr 20, 2017
f0b7025
errors: use lazy assert to avoid issues on startup
jasnell Apr 20, 2017
7632761
errors, child_process: migrate to using internal/errors
jasnell Feb 10, 2017
a4fd9e5
test: chdir before running test-cli-node-options
danbev Apr 26, 2017
972bfe1
n-api: Sync with back-compat changes
jasongin Apr 26, 2017
f11d4a1
test: use common.mustCall in test-https-strict
weewey Apr 26, 2017
71f22c8
doc: replace uses of `you` and other style nits
jasnell Apr 26, 2017
b16869c
test: remove AIX guard in fs-options-immutable
thefourtheye Apr 27, 2017
8d1f15b
test: remove eslint comments
cjihrig Apr 26, 2017
b2c7a51
test: remove eslint comments from test-util.js
cjihrig Apr 26, 2017
71911be
doc: clarify arch support for power platforms
mhdawson Apr 26, 2017
3a0058c
doc: document url.domainTo* methods separately
TimothyGu Apr 27, 2017
9d4bb55
doc: add Added-in metadata for WHATWG URL
TimothyGu Apr 27, 2017
deb9622
doc: Add initial documentation for N-API
mhdawson Apr 19, 2017
bed4612
benchmark: add benchmark for v8.getHeap*Statistics
jasnell Apr 26, 2017
1052383
v8: refactor struture of v8 module
jasnell Apr 26, 2017
0101a8f
test: add relative path to accommodate limit
Apr 22, 2017
8092fb0
doc: fix examples in repl.md
vsemozhetbyt Apr 27, 2017
d8f8096
doc: update example in repl.md
vsemozhetbyt Apr 27, 2017
a1a54ca
benchmark: terminate child process on Windows
Trott Apr 25, 2017
427cd29
test: add hasCrypto check to test-cli-node-options
danbev Apr 27, 2017
d5db4d2
test: cleanup handles in test_environment
addaleax Apr 27, 2017
719247f
src: remove debugger dead code
targos Apr 24, 2017
3d87eca
test,doc: document `crashOnUnhandledRejection()`
addaleax Apr 27, 2017
7c238be
test: improve test-tcp-wrap-listen
QueueHefner Apr 22, 2017
b331ba6
url: move to module.exports = {} pattern
jasnell Apr 28, 2017
97ec72b
url: refactor binding imports in internal/url
jasnell Apr 28, 2017
b07e1a8
v8: fix gcc 7 build errors
Apr 26, 2017
765be6c
doc: fixup the collaborators list
aqrln Apr 29, 2017
74f61e8
test: support multiple warnings in checkWarning
apexskier Mar 13, 2017
a3132b0
process: cast promise rejection reason to string
apexskier Mar 13, 2017
0324ac6
test: add inspect-brk option to cluster module
dave-k Apr 19, 2017
0142276
test: replace indexOf with includes
gwer Apr 22, 2017
91ccea6
test: fix test filenames
mscdex Apr 17, 2017
7a5bac5
build: add target for checking for perm deopts
mscdex Apr 17, 2017
e283319
http: fix permanent deoptimizations
mscdex Apr 24, 2017
e9c02c6
stream: fix permanent deoptimizations
mscdex Apr 24, 2017
e8a4290
fs: fix permanent deoptimizations
mscdex Apr 24, 2017
033ea99
cluster: fix permanent deoptimizations
mscdex Apr 24, 2017
a641b7c
process: fix permanent deoptimizations
mscdex Apr 24, 2017
8491c70
url: fix permanent deoptimizations
mscdex Apr 24, 2017
d5925af
util: fix permanent deoptimizations
mscdex Apr 24, 2017
3c098ee
net: fix permanent deoptimizations
mscdex Apr 24, 2017
4484e8f
readline: fix permanent deoptimizations
mscdex Apr 24, 2017
b45abfd
repl: fix permanent deoptimizations
mscdex Apr 24, 2017
b6da225
test: fix permanent deoptimizations
mscdex Apr 24, 2017
aa3eab0
doc: fix formatting of TOC
refack Apr 28, 2017
0833d31
test: move test to sequential for reliability
Trott Apr 27, 2017
6ed791c
deps: cherry-pick bfae9db from upstream v8
bnoordhuis Apr 28, 2017
0f58d3c
src: support domains with empty labels
watilde May 1, 2017
579ff2a
process: refactor internal/process.js export style
jasnell Apr 24, 2017
ed0716f
module: refactor internal/module export style
jasnell Apr 24, 2017
e2199e0
streams: refactor BufferList into ES6 class
jasnell Apr 24, 2017
08809f2
fs: simplify constant decls
jasnell Apr 25, 2017
ea9eed5
freelist: simplify export
jasnell Apr 25, 2017
473572e
os: refactor os structure, add Symbol.toPrimitive
jasnell Apr 25, 2017
23fc082
test: remove extra console output from test-os.js
jasnell Apr 25, 2017
dd20e68
process: add optional detail to process emitWarning
jasnell Apr 28, 2017
a180259
test,lib,doc: use function declarations
Trott Apr 28, 2017
aea7269
tools: require function declarations
Trott Apr 28, 2017
595d4ec
tools: ignore node_trace.*.log
watilde May 2, 2017
10ccf56
test: skipIfInspectorDisabled cluster-inspect-brk
danbev Apr 30, 2017
9f7b549
Revert "test: remove eslint comments"
joyeecheung Apr 29, 2017
9802d46
2017-05-02, Version 4.8.3 'Argon' (Maintenance)
MylesBorins Apr 19, 2017
20e27dd
2017-05-02, Version 6.10.3 'Boron' (LTS)
MylesBorins Apr 19, 2017
9d723e8
buffer: remove pointless C++ utility methods
addaleax Apr 30, 2017
dc3bbb4
cluster: remove debug arg handling
Trott Apr 29, 2017
c20e87a
repl: fix /dev/null history file regression
mscdex Apr 30, 2017
133fb0c
test: minor fixes to test-module-loading.js
ywalterh Apr 28, 2017
04796ee
test: increase coverage of buffer
DavidCai1111 Apr 28, 2017
871fb5a
2017-05-02, Version 7.10.0 (Current)
evanlucas May 1, 2017
cd32b77
n-api: remove unnecessary try-catch bracket from certain APIs
Apr 27, 2017
d6a6bcd
stream: remove unnecessary parameter
Aug 17, 2016
e488857
build: add static option to vcbuild.bat
Apr 30, 2017
896be83
node: add missing option to --help output
krydos Apr 30, 2017
2bf461e
doc: document vm timeout option perf impact
addaleax Apr 29, 2017
55c95b1
http: fix first body chunk fast case for UTF-16
addaleax Apr 29, 2017
6993eb0
stream: fix y.pipe(x)+y.pipe(x)+y.unpipe(x)
addaleax Apr 29, 2017
21653b6
src: add --napi-modules to whitelist
mhdawson Apr 28, 2017
8aca66a
test: fix warning in n-api reference test
mhdawson Apr 28, 2017
b2ab41e
test: increase readline coverage
addaleax Apr 27, 2017
9990be2
src: turn buffer type-CHECK into exception
addaleax Apr 29, 2017
6c2daf0
crypto: throw proper errors if out enc is UTF-16
addaleax Apr 29, 2017
d56a7e6
src: do proper StringBytes error handling
addaleax Apr 30, 2017
eb535c5
doc: deprecate vm.runInDebugContext
joshgav May 3, 2017
ff001c1
test: move WPT to its own testing module
Trott Apr 29, 2017
4677766
test: enable test-debugger-pid
Trott Apr 30, 2017
ebcd8c6
src: rename CryptoPemCallback -> PasswordCallback
danbev May 2, 2017
d0c968e
src: make root_cert_vector function scoped
danbev May 2, 2017
c1b3b95
doc: add WHATWG file URLs in fs module
Apr 25, 2017
e48d58b
assert: fix AssertionError, assign error code
jasnell Apr 25, 2017
6ade7f3
src: update --inspect hint text
joshgav Apr 5, 2017
3f48ab3
inspector: do not add 'inspector' property
Apr 25, 2017
f971916
test: fix too optimistic guess in setproctitle
vsemozhetbyt May 2, 2017
712596f
test: add callback to fs.close() in test-fs-chmod
vsemozhetbyt May 2, 2017
0258aed
doc: edit CONTRIBUTING.md for clarity etc.
Trott May 2, 2017
943dd5f
url: handle windows drive letter in the file state
watilde May 3, 2017
665695f
test: add callback to fs.close() in test-fs-stat
vsemozhetbyt May 3, 2017
53c88fa
tools: remove unused code from test.py
Trott May 3, 2017
bc05436
test: add regex check in test-vm-is-context
Jeyanthinath May 2, 2017
1c93e8c
win: make buildable on VS2017
refack Apr 7, 2017
94a120c
test: add coverage for error apis
mhdawson Apr 28, 2017
f1d593c
test: make tests cwd-independent
vsemozhetbyt May 3, 2017
feb90d3
tools: relax lint rule for regexps
Trott May 3, 2017
6bcf65d
lib,test: use regular expression literals
Trott May 3, 2017
8b76c3e
test: reduce string concatenations
vsemozhetbyt Apr 28, 2017
2614d24
doc: update readFileSync in fs.md
thelostone-mc May 2, 2017
15e160e
inspector: report when main context is destroyed
May 3, 2017
4703824
doc: fix commit guideline url
watson May 5, 2017
68c933c
test: fix flakyness with `yes.exe`
refack May 4, 2017
73d9c0f
test: port test for make_callback to n-api
digitalinfinity Apr 14, 2017
60d1aac
deps: update V8 to 5.8.283.38
targos May 2, 2017
5b63fab
src: update NODE_MODULE_VERSION to 55
targos May 2, 2017
bf5c309
build: fix V8 build on FreeBSD
targos May 5, 2017
7becb19
deps: limit regress/regress-crbug-514081 v8 test
mhdawson May 9, 2016
14dc300
v8: fix stack overflow in recursive method
bnoordhuis Apr 17, 2017
0f3e69d
v8: fix gcc 7 build errors
Apr 26, 2017
6690415
deps: cherry-pick a927f81c7 from V8 upstream
addaleax Mar 8, 2017
fe15fe7
deps: backport ec1ffe3 from upstream V8
danbev Mar 27, 2017
d74a545
deps: cherry-pick bfae9db from upstream v8
bnoordhuis Apr 28, 2017
1c834e7
errors,test: migrating error to internal/errors
larissayvette Feb 21, 2017
3fd890a
test: add mustCall in timers-unrefed-in-callback
ChatbotSchool Apr 22, 2017
7e5f500
assert: improve deepEqual perf for large input
addaleax May 5, 2017
a710e44
test: complete coverage of buffer
DavidCai1111 May 5, 2017
a398516
doc: remove test-npm from general build doc
Trott May 4, 2017
9318f82
readline: use module.exports = {}
jasnell Apr 29, 2017
392a898
readline: use module.exports = {} on internal/readline
jasnell Apr 29, 2017
4ac7a68
readline: multiple code cleanups
jasnell Apr 29, 2017
4c070d4
readline: move escape codes into internal/readline
jasnell Apr 30, 2017
d37f27a
test: expand test coverage of readline
jasnell Apr 30, 2017
dac9f42
test: remove common.PORT in test tls ticket cluster
ooHmartY Apr 28, 2017
6058c43
test: refactored test-repl-persistent-history
cool88 May 2, 2017
152966d
test: refactoring test with common.mustCall
weewey Apr 28, 2017
cbd6fde
doc: improve path.posix.normalize docs
sjlehn Apr 27, 2017
42958d1
test: refactor test-querystring
lukaszewczak Apr 25, 2017
0a734fe
test: fix napi test_reference for recent V8
targos May 5, 2017
ea1b8a5
doc: sort bottom-of-file markdown links
sam-github May 8, 2017
f6247a9
assert: restore TypeError if no arguments
Trott May 5, 2017
dc4313c
test: remove unused testpy code
Trott May 5, 2017
65d6249
benchmark: update an obsolete path
vsemozhetbyt May 8, 2017
212a7a6
net: ensure net.connect calls Socket connect
watson May 5, 2017
dd06246
meta: fix nits in README.md collaborators list
vsemozhetbyt May 5, 2017
771568a
test: add test for timers benchmarks
joyeecheung May 5, 2017
cf980b0
net: check and throw on error for getsockname
danbev May 6, 2017
f72376d
test: add skipIfInspectorDisabled to debugger-pid
danbev May 7, 2017
059f296
util: add internal bindings for promise handling
addaleax Apr 14, 2017
99da8e8
util: add util.promisify()
addaleax Apr 14, 2017
3ea2301
test: add a bunch of tests from bluebird
MadaraUchiha Apr 18, 2017
e965ed1
test: add test for promisify customPromisifyArgs
giltayar Apr 18, 2017
e7c5145
timers: add promisify support
addaleax Apr 14, 2017
fbcb4f5
fs: support util.promisify for fs.read/fs.write
addaleax Apr 16, 2017
fe5ca3f
child_process: support promisified `exec(File)`
addaleax Apr 16, 2017
faf6654
dns: support promisified `lookup(Service)`
addaleax Apr 16, 2017
e429f9a
doc: fix typo in streams.md
glennschler May 9, 2017
4cb5f3d
fs: throw on invalid callbacks for async functions
thefourtheye Apr 21, 2017
2bbabb1
n-api: napi_get_cb_info should fill array
jasongin May 5, 2017
2e3fef7
n-api: Handle fatal exception in async callback
jasongin May 4, 2017
824fb49
lib: remove useless default caught
JacksonTian May 7, 2017
94eed0f
test: use dynamic port instead of common.PORT
thelostone-mc Apr 17, 2017
147048a
doc: fix broken links in n-api doc
mhdawson May 7, 2017
5d0a770
deps: ICU 59.1 bump
srl295 Apr 13, 2017
57a08e2
test: remove obsolete lint config comments
Trott May 6, 2017
e1cabf6
doc, test: add note to response.getHeaders
refack May 7, 2017
317180f
test: fix flaky test-https-client-get-url
May 8, 2017
cfe7b34
test: use assert regexp in tls no cert test
arturgvieira May 8, 2017
13487c4
doc: add docs for server.address() for pipe case
Flarna May 8, 2017
dd6e3f6
src: fix comments re PER_ISOLATE macros
joshgav May 8, 2017
4b9d84d
tty_wrap: throw when uv_tty_init() returns error
trevnorris Apr 11, 2017
732620c
test: remove unneeded tests
trevnorris Mar 3, 2017
0432c6e
async_wrap: use double, not int64_t, for async id
trevnorris Dec 13, 2016
d9f3ec8
crypto: use named FunctionTemplate
trevnorris Sep 28, 2016
f1ed19d
async_wrap: use more specific providers
trevnorris Nov 2, 2016
fe2df3b
async_wrap,src: add GetAsyncId() method
trevnorris Nov 2, 2016
c0bde73
src: implement native changes for async_hooks
trevnorris Mar 7, 2017
7e3a3c9
async_hooks: initial async_hooks implementation
trevnorris Mar 9, 2017
4a7233c
lib: implement async_hooks API in core
trevnorris Mar 10, 2017
e3e56f1
test: adding tests for initHooks API
thlorenz Nov 22, 2016
c68ebe8
makefile: add async-hooks to test and test-ci
trevnorris Apr 5, 2017
6914aea
test: detect all types of aborts in windows
gireeshpunathil May 5, 2017
54d3318
lib: add guard to originalConsole
danbev May 7, 2017
bee250c
test: dynamic port in cluster disconnect
May 4, 2017
bb88cae
build: fix ninja build failure
danbev Apr 18, 2017
9fd22bc
build: fix ninja build failure (GYP patch)
danbev Apr 18, 2017
654afa2
test: improve n-api array func coverage
mhdawson May 7, 2017
631cb42
test: favor deepStrictEqual over deepEqual
Trott May 7, 2017
abfd4bf
doc: clarify node.js addons are c++
BethGriggs May 8, 2017
9ce2271
https: support agent construction without new
cjihrig May 9, 2017
b6001a2
src: make SIGPROF message a real warning
cjihrig Apr 27, 2017
c79deaa
doc: update to add ref to supported platforms
mhdawson May 9, 2017
6f449db
fs: refactor deprecated functions for readability
Trott May 9, 2017
a82e0e6
benchmark: check for time precision in common.js
Trott May 9, 2017
d7d16f7
doc: Change options at STEP 5 in CONTRIBUTING.md
kysnm May 4, 2017
9f8e030
src: add/move hasCrypto checks for async tests
danbev May 11, 2017
1541079
src: add HAVE_OPENSSL guard to crypto providers
danbev May 11, 2017
529e4f2
test: make a test path-independent
vsemozhetbyt May 10, 2017
56812c8
test: use dynamic port in test-https-connect-address-family
arturgvieira May 9, 2017
1d5f5aa
doc: update COLLABORATOR_GUIDE.md
morrme May 12, 2017
642bd4d
test: add a simple abort check in windows
May 9, 2017
7c3a23b
inspector: handle socket close before close frame
May 9, 2017
98609fc
timers: do not use user object call/apply
Trott May 11, 2017
3fa5d80
benchmark: chunky http client should exit with 0
joyeecheung May 9, 2017
84fc069
test: move test-dgram-bind-shared-ports to sequential
orafaelfragoso Apr 16, 2017
9516aa1
test: add common.mustCall() to NAPI exception test
Trott May 11, 2017
945f208
test: make the rest of tests path-independent
vsemozhetbyt May 11, 2017
b5ae22d
test: add hasCrypto check to https-agent-constructor
danbev May 12, 2017
b7bc09f
test: add not-called check to heap-profiler test
Trott May 11, 2017
72e3dda
test: use mustCall in tls-connect-given-socket
vperezma Apr 22, 2017
60f0dc7
src: rename CONNECTION provider to SSLCONNECTION
danbev May 12, 2017
32f01c8
src: remove unused uv.h include in async-wrap.h
danbev May 11, 2017
88d2e69
test: remove unneeded string splitting
vsemozhetbyt May 12, 2017
f439065
deps: cherry-pick 4ae5993 from upstream OpenSSL
shigeki May 9, 2017
e896898
deps: update openssl asm and asm_obsolete files
shigeki May 9, 2017
ef16319
util: fixup internal util exports
jasnell May 12, 2017
b23d414
tls: do not wrap net.Socket with StreamWrap
krydos May 2, 2017
2767209
addons: remove semicolons from after module definition
May 9, 2017
e600fbe
tls: accept `lookup` option for `tls.connect()`
indutny May 4, 2017
1b28022
doc: clarify operation of napi_cancel_async_work
mhdawson May 11, 2017
47c3c58
test: improve N-API test coverage
mhdawson May 12, 2017
0083011
n-api: remove compiler warning
addaleax May 13, 2017
0c2edd2
test: fixed flaky test-net-connect-local-error
May 15, 2017
986e1d2
deps: cherry-pick f5fad6d from upstream v8
danbev May 2, 2017
fefab90
src: only call FatalException if not verbose
danbev May 3, 2017
92f3b30
doc: document method for reverting commits
gibfahn May 13, 2017
7906ed5
test: add regex check in test-url-parse-invalid-input
andreicioromila May 7, 2017
11918c4
stream: fix highWaterMark integer overflow
tniessen May 10, 2017
4aff056
build: reduce one level of spawning in node_gyp
refack Apr 25, 2017
8035527
build: simplify `if` in setting of arg_paths
refack Apr 26, 2017
53dae83
src: fix --abort_on_uncaught_exception arg parsing
sam-github May 12, 2017
f2ba06d
benchmark: remove redundant timers benchmark
Trott May 12, 2017
ad7b98b
build: don't print directory for GNUMake
danbev May 15, 2017
5debcce
test: add hasCrypto to tls-wrap-event-emmiter
danbev May 15, 2017
6342988
build: clean up napi build in test-addons-clean
joyeecheung May 15, 2017
ca32671
Merge nodejs/node into xplat
kunalspathak May 17, 2017
bfbf736
chakrashim, test: Build failures and skipped test
kunalspathak May 11, 2017
297b176
Merge nodejs/node into xplat
kunalspathak May 16, 2017
16922b4
Fix N-API JSRT bugs found by new tests
jasongin May 16, 2017
75c91ca
chakrashim: Fixed build errors
kunalspathak May 16, 2017
a8d0006
build,test: Fixed test and build issue
kunalspathak May 16, 2017
d07825c
Merge nodejs/master to xplat
kunalspathak May 18, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
6 changes: 5 additions & 1 deletion .eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ rules:
eol-last: 2
func-call-spacing: 2
func-name-matching: 2
func-style: [2, declaration, {allowArrowFunctions: true}]
indent: [2, 2, {ArrayExpression: first,
CallExpression: {arguments: first},
MemberExpression: 1,
Expand All @@ -105,7 +106,10 @@ rules:
key-spacing: [2, {mode: minimum}]
keyword-spacing: 2
linebreak-style: [2, unix]
max-len: [2, {code: 80, ignoreUrls: true, tabWidth: 2}]
max-len: [2, {code: 80,
ignoreRegExpLiterals: true,
ignoreUrls: true,
tabWidth: 2}]
new-parens: 2
no-mixed-spaces-and-tabs: 2
no-multiple-empty-lines: [2, {max: 2, maxEOF: 0, maxBOF: 0}]
Expand Down
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes
- [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines)
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)

##### Affected core subsystem(s)
<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ node_g
.benchmark_reports
icu_config.gypi
.eslintcache
node_trace.*.log

/out

Expand Down
17 changes: 5 additions & 12 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ Support is divided into three tiers:
|--------------|--------------|----------------------------------|----------------------|------------------|
| GNU/Linux | Tier 1 | kernel >= 2.6.18, glibc >= 2.5 | x86, x64, arm, arm64 | |
| macOS | Tier 1 | >= 10.10 | x64 | |
| Windows | Tier 1 | >= Windows 7 or >= Windows2008R2 | x86, x64 | |
| Windows | Tier 1 | >= Windows 7 / 2008 R2 | x86, x64 | vs2015 or vs2017 |
| SmartOS | Tier 2 | >= 15 < 16.4 | x86, x64 | see note1 |
| FreeBSD | Tier 2 | >= 10 | x64 | |
| GNU/Linux | Tier 2 | kernel >= 3.13.0, glibc >= 2.19 | ppc64le | |
| AIX | Tier 2 | >= 7.1 TL04 | ppc64be | |
| GNU/Linux | Tier 2 | kernel >= 3.13.0, glibc >= 2.19 | ppc64le >=power8 | |
| AIX | Tier 2 | >= 7.1 TL04 | ppc64be >=power7 | |
| GNU/Linux | Tier 2 | kernel >= 3.10, glibc >= 2.17 | s390x | |
| macOS | Experimental | >= 10.8 < 10.10 | x64 | no test coverage |
| Linux (musl) | Experimental | musl >= 1.0 | x64 | |
Expand Down Expand Up @@ -123,15 +123,6 @@ To run the tests:
$ make test
```

To run the npm test suite:

*note: to run the suite on node v4 or earlier you must first*
*run `make install`*

```console
$ make test-npm
```

To build the documentation:

This will build Node.js first (if necessary) and then use it to build the docs:
Expand Down Expand Up @@ -175,6 +166,8 @@ Prerequisites:
* [Visual Studio 2015 Update 3](https://www.visualstudio.com/), all editions
including the Community edition (remember to select
"Common Tools for Visual C++ 2015" feature during installation).
* [Visual Studio 2017](https://www.visualstudio.com/downloads/), any edition (including the Build Tools SKU).
__Required Components:__ "MSbuild", "VC++ 2017 v141 toolset" and one of the Windows SDKs (10 or 8.1).
* Basic Unix tools required for some tests,
[Git for Windows](http://git-scm.com/download/win) includes Git Bash
and tools which can be included in the global `PATH`.
Expand Down
9 changes: 6 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V7.md#7.9.0">7.9.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V7.md#7.10.0">7.10.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V7.md#7.9.0">7.9.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V7.md#7.8.0">7.8.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V7.md#7.7.4">7.7.4</a><br/>
<a href="doc/changelogs/CHANGELOG_V7.md#7.7.3">7.7.3</a><br/>
Expand All @@ -45,7 +46,8 @@ release.
<a href="doc/changelogs/CHANGELOG_V7.md#7.0.0">7.0.0</a><br/>
</td>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V6.md#6.10.2">6.10.2</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V6.md#6.10.3">6.10.3</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.10.2">6.10.2</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.10.1">6.10.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.10.0">6.10.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V6.md#6.9.5">6.9.5</a><br/>
Expand Down Expand Up @@ -89,7 +91,8 @@ release.
<a href="doc/changelogs/CHANGELOG_V5.md#5.0.0">5.0.0</a><br/>
</td>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V4.md#4.8.2">4.8.2</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V4.md#4.8.3">4.8.3</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V4.md#4.8.2">4.8.2</a><br/>
<a href="doc/changelogs/CHANGELOG_V4.md#4.8.1">4.8.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V4.md#4.8.0">4.8.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V4.md#4.7.3">4.7.3</a><br/>
Expand Down
43 changes: 36 additions & 7 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@

* [Issues and Pull Requests](#issues-and-pull-requests)
* [Accepting Modifications](#accepting-modifications)
- [Internal vs. Public API](#internal-vs-public-api)
- [Breaking Changes](#breaking-changes)
- [Deprecations](#deprecations)
- [Involving the CTC](#involving-the-ctc)
- [Useful CI Jobs](#useful-ci-jobs)
- [Internal vs. Public API](#internal-vs-public-api)
- [Breaking Changes](#breaking-changes)
- [Deprecations](#deprecations)
- [Involving the CTC](#involving-the-ctc)
* [Landing Pull Requests](#landing-pull-requests)
- [Technical HOWTO](#technical-howto)
- [I Just Made a Mistake](#i-just-made-a-mistake)
- [Long Term Support](#long-term-support)
- [Technical HOWTO](#technical-howto)
- [I Just Made a Mistake](#i-just-made-a-mistake)
- [Long Term Support](#long-term-support)

This document contains information for Collaborators of the Node.js
project regarding maintaining the code, documentation and issues.
Expand Down Expand Up @@ -87,6 +88,27 @@ All pull requests that modify executable code should be subjected to
continuous integration tests on the
[project CI server](https://ci.nodejs.org/).

#### Useful CI Jobs

* [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)
is the standard CI run we do to check Pull Requests. It triggers `node-test-commit`,
which runs the `build-ci` and `test-ci` targets on all supported platforms.

* [`node-test-linter`](https://ci.nodejs.org/job/node-test-linter/)
only runs the linter targets, which is useful for changes that only affect comments
or documentation.

* [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/)
uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run `npm install && npm test`
on a large selection of common modules. This is useful to check whether a
change will cause breakage in the ecosystem. To test Node.JS ABI changes
you can run [`citgm-abi-smoker`](https://ci.nodejs.org/job/citgm-abi-smoker/).

* [`node-stress-single-test`](https://ci.nodejs.org/job/node-stress-single-test/)
is designed to allow one to run a group of tests over and over on a specific
platform to confirm that the test is reliable.


### Internal vs. Public API

Due to the nature of the JavaScript language, it can often be difficult to
Expand Down Expand Up @@ -230,6 +252,13 @@ not can often be based on many complex factors that are not easily codified. It
is also possible that the breaking commit can be labeled retroactively as a
semver-major change that will not be backported to Current or LTS branches.

##### Reverting commits

Commits are reverted with `git revert <HASH>`, or `git revert <FROM>..<TO>` for
multiple commits. Commit metadata and the reason for the revert should be
appended. Commit message rules about line length and subsystem can be ignored.
A Pull Request should be raised and approved like any other change.

### Deprecations

Deprecation refers to the identification of Public APIs that should no longer
Expand Down
122 changes: 57 additions & 65 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,38 +2,30 @@

## Code of Conduct

The Code of Conduct explains the *bare minimum* behavior
expectations the Node Foundation requires of its contributors.
[Please read it before participating.](https://github.com/nodejs/TSC/blob/master/CODE_OF_CONDUCT.md)
Please read the
[Code of Conduct](https://github.com/nodejs/TSC/blob/master/CODE_OF_CONDUCT.md)
which explains the minimum behavior expectations for Node.js contributors.

## Issue Contributions

When opening new issues or commenting on existing issues on this repository
please make sure discussions are related to concrete technical issues with the
Node.js software.
When opening issues or commenting on existing issues, please make sure
discussions are related to concrete technical issues with Node.js.

For general help using Node.js, please file an issue at the
* For general help using Node.js, please file an issue at the
[Node.js help repository](https://github.com/nodejs/help/issues).

Discussion of non-technical topics including subjects like intellectual
property, trademark, and high level project questions should move to the
[Technical Steering Committee (TSC)](https://github.com/nodejs/TSC/issues)
instead.
* Discussion of non-technical topics (such as intellectual property and
trademark) should use the
[Technical Steering Committee (TSC) repository](https://github.com/nodejs/TSC/issues).

## Code Contributions

The Node.js project has an open governance model and welcomes new contributors.
Individuals making significant and valuable contributions are made
_Collaborators_ and given commit-access to the project. See the
[GOVERNANCE.md](./GOVERNANCE.md) document for more information about how this
works.

This document will guide you through the contribution process.
This section will guide you through the contribution process.

### Step 1: Fork

Fork the project [on GitHub](https://github.com/nodejs/node) and check out your
copy locally.
Fork the project [on GitHub](https://github.com/nodejs/node) and clone your fork
locally.

```text
$ git clone [email protected]:username/node.git
Expand All @@ -49,24 +41,18 @@ and built upon.
#### Dependencies

Node.js has several bundled dependencies in the *deps/* and the *tools/*
directories that are not part of the project proper. Any changes to files
in those directories or its subdirectories should be sent to their respective
projects. Do not send a patch to Node.js. We cannot accept such patches.
directories that are not part of the project proper. Changes to files in those
directories should be sent to their respective projects. Do not send a patch to
Node.js. We cannot accept such patches.

In case of doubt, open an issue in the
[issue tracker](https://github.com/nodejs/node/issues/) or contact one of the
[project Collaborators](https://github.com/nodejs/node/#current-project-team-members).
Especially do so if you plan to work on something big. Nothing is more
frustrating than seeing your hard work go to waste because your vision
does not align with the project team. (Node.js has two IRC channels:
Node.js has two IRC channels:
[#Node.js](http://webchat.freenode.net/?channels=node.js) for general help and
questions, and
[#Node-dev](http://webchat.freenode.net/?channels=node-dev) for development of
Node.js core specifically).

For instructions on updating the version of V8 included in the *deps/*
directory, please refer to [the Maintaining V8 in Node.js guide](https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md).

Node.js core specifically.

### Step 2: Branch

Expand Down Expand Up @@ -95,35 +81,37 @@ $ git add my/changed/files
$ git commit
```

### Commit guidelines
### Commit message guidelines

Writing good commit logs is important. A commit log should describe what
changed and why. Follow these guidelines when writing one:
The commit message should describe what changed and why.

1. The first line should:
- contain a short description of the change
- be 50 characters or less
- be entirely in lowercase with the exception of proper nouns, acronyms, and
the words that refer to code, like function/variable names
- be prefixed with the name of the changed subsystem and start with an
imperative verb. Examples: "net: add localAddress and localPort
to Socket", "src: fix typos in node_lttng_provider.h"
- be meaningful; it is what other people see when they
run `git shortlog` or `git log --oneline`.<br>
Check the output of `git log --oneline files/you/changed` to find out
what subsystem (or subsystems) your changes touch
imperative verb. Check the output of `git log --oneline files/you/changed` to
find out what subsystems your changes touch.

Examples:
- `net: add localAddress and localPort to Socket`
- `src: fix typos in node_lttng_provider.h`


2. Keep the second line blank.
3. Wrap all other lines at 72 columns.
- If your patch fixes an open issue, you can add a reference to it at the end
of the log. Use the `Fixes:` prefix and the full issue URL. For other references
use `Refs:`. For example:
```txt
Fixes: https://github.com/nodejs/node/issues/1337
Refs: http://eslint.org/docs/rules/space-in-parens.html
Refs: https://github.com/nodejs/node/pull/3615
```

A good commit log can look something like this:
4. If your patch fixes an open issue, you can add a reference to it at the end
of the log. Use the `Fixes:` prefix and the full issue URL. For other references
use `Refs:`.

Examples:
- `Fixes: https://github.com/nodejs/node/issues/1337`
- `Refs: http://eslint.org/docs/rules/space-in-parens.html`
- `Refs: https://github.com/nodejs/node/pull/3615`

Sample complete commit message:

```txt
subsystem: explain the commit in one line
Expand All @@ -143,7 +131,8 @@ Refs: http://eslint.org/docs/rules/space-in-parens.html

### Step 4: Rebase

Use `git rebase` (not `git merge`) to sync your work from time to time.
Use `git rebase` (not `git merge`) to synchronize your work with the main
repository.

```text
$ git fetch upstream
Expand All @@ -152,12 +141,12 @@ $ git rebase upstream/master

### Step 5: Test

Bug fixes and features **should come with tests**. Add your tests in the
`test/parallel/` directory. For guidance on how to write a test for the Node.js
project, see this [guide](./doc/guides/writing-tests.md). Looking at other tests
to see how they should be structured can also help.
Bug fixes and features should come with tests. Read the
[guide for writing tests in Node.js](./doc/guides/writing-tests.md). Looking at
other tests to see how they should be structured can also help. Add your
tests in the `test/parallel/` directory if you are unsure where to put them.

To run the tests on Unix / macOS:
To run the tests (including code linting) on Unix / macOS:

```text
$ ./configure && make -j4 test
Expand All @@ -174,28 +163,31 @@ Windows:
Make sure the linter does not report any issues and that all tests pass. Please
do not submit patches that fail either check.

Running `make test`/`vcbuild test` will run the linter as well unless one or
more tests fail.

If you want to run the linter without running tests, use
`make lint`/`vcbuild lint`. It will run both JavaScript linting and
C++ linting.

If you are updating tests and just want to run a single test to check it, you
can use this syntax to run it exactly as the test harness would:
If you are updating tests and just want to run a single test to check it:

```text
$ python tools/test.py -J --mode=release parallel/test-stream2-transform
```

If you want to check the other options, please refer to the help by using
the `--help` option

```text
$ python tools/test.py -v --mode=release parallel/test-stream2-transform
$ python tools/test.py --help
```

You can run tests directly with node:
You can usually run tests directly with node:

```text
$ ./node ./test/parallel/test-stream2-transform.js
```

Remember to recompile with `make -j4` in between test runs if you change
core modules.
Remember to recompile with `make -j4` in between test runs if you change code in
the `lib` or `src` directories.

### Step 6: Push

Expand All @@ -208,7 +200,7 @@ Pull requests are usually reviewed within a few days.
### Step 7: Discuss and update

You will probably get feedback or requests for changes to your Pull Request.
This is a big part of the submission process so don't be disheartened!
This is a big part of the submission process so don't be discouraged!

To make changes to an existing Pull Request, make the changes to your branch.
When you push that branch to your fork, GitHub will automatically update the
Expand Down
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ The externally maintained libraries used by Node.js are:
"""
COPYRIGHT AND PERMISSION NOTICE (ICU 58 and later)

Copyright © 1991-2016 Unicode, Inc. All rights reserved.
Copyright © 1991-2017 Unicode, Inc. All rights reserved.
Distributed under the Terms of Use in http://www.unicode.org/copyright.html

Permission is hereby granted, free of charge, to any person obtaining
Expand Down
Loading