[Merge chakra-core/ChakraCore@8dd1b47365] [MERGE #3721 @jianchun] fix…

… incorrect parameter to call ChangeStringLinguisticCase Merge pull request #3721 from jianchun:localfix 2nd call to ChangeStringLinguisticCase() was incorrectly passing buffer size as source length. Fix #3531
nodejs · Sep 25, 2017 · e155292 · e155292
1 parent c3abd0a
commit e155292
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/deps/chakrashim/core/lib/Runtime/Library/JavascriptString.cpp b/deps/chakrashim/core/lib/Runtime/Library/JavascriptString.cpp
@@ -3357,7 +3357,7 @@ namespace Js
         BufferStringBuilder builder(count, scriptContext);
         char16* stringBuffer = builder.DangerousGetWritableBuffer();
 
-        int count1 = PlatformAgnostic::UnicodeText::ChangeStringLinguisticCase(caseFlags, str, count, stringBuffer, count, &err);
+        int count1 = PlatformAgnostic::UnicodeText::ChangeStringLinguisticCase(caseFlags, str, strLength, stringBuffer, count, &err);
 
         if (count1 <= 0)
         {

diff --git a/deps/chakrashim/core/test/Strings/stringBuiltin.js b/deps/chakrashim/core/test/Strings/stringBuiltin.js
@@ -217,3 +217,6 @@ a = b;
 Object.prototype.toUpperCase = String.prototype.toUpperCase;
 var f = obj.toUpperCase();
 WScript.Echo (a);
+
+// #3531
+"\u00DF".toLocaleUpperCase();