chakrashim: Fix SetAccessorProperty behavior

`FunctionTemplate` asserts that it can get the external data from the provided object. The assert was hitting because the caller was passing in an empty `Local<FunctionTemplate>` object. PR-URL: #454 Reviewed-By: Taylor Woll <[email protected]>
nodejs · Jan 26, 2018 · d910601 · d910601
1 parent 11035cf
commit d910601
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/deps/chakrashim/src/v8template.cc b/deps/chakrashim/src/v8template.cc
@@ -57,8 +57,8 @@ void Template::SetAccessorProperty(
   if (properties != nullptr) {
     properties->SetAccessorProperty(
         name,
-        getter->GetFunction(),
-        setter->GetFunction(),
+        !getter.IsEmpty() ? getter->GetFunction() : Local<Function>(),
+        !setter.IsEmpty() ? setter->GetFunction() : Local<Function>(),
         attribute,
         access_control);
   }