Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
chakrashim: isMapIterator/isSetIterator bug fix
Browse files Browse the repository at this point in the history
We added special symbol to detect  mapIterator and setIterator.
IsMapIterator and IsSetIterator extracts the value of the symbol to
check if the object is map or set iterator. However built in objects like
'process' has native getter set that converts the lookup properties to
string. Symbols throws type error for implicit toString conversion and
hence the error.

I changed the symbol key to string key and verified unit test.
Morever string properties will be helpful when we clone objects in cross
context scenarios since we iterate on getOwnPropertyNames and not
on getOwnPropertySymbols (utils.cloneObject method).

Also included chakra_shim.js in jslint.

Reviewed-By: @jianchun
  • Loading branch information
kunalspathak committed Nov 13, 2015
1 parent 82ad0b3 commit c9cf4ff
Show file tree
Hide file tree
Showing 2 changed files with 134 additions and 132 deletions.
Loading

0 comments on commit c9cf4ff

Please sign in to comment.