chakrashim: add shim for Template::SetAccessorProperty

nodejs · Jan 19, 2018 · c3abf1c · c3abf1c
1 parent bed3bf9
commit c3abf1c
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 5 deletions.
diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -2246,6 +2246,14 @@ class V8_EXPORT Template : public Data {
   V8_INLINE void Set(Isolate* isolate, const char* name, Local<Data> value) {
     Set(v8::String::NewFromUtf8(isolate, name), value);
   }
+
+  void SetAccessorProperty(
+      Local<Name> name,
+      Local<FunctionTemplate> getter = Local<FunctionTemplate>(),
+      Local<FunctionTemplate> setter = Local<FunctionTemplate>(),
+      PropertyAttribute attribute = None,
+      AccessControl settings = DEFAULT);
+
  private:
   Template();
 };

diff --git a/deps/chakrashim/src/v8template.cc b/deps/chakrashim/src/v8template.cc
@@ -27,20 +27,41 @@ namespace v8 {
 Template::Template() {
 }
 
-void Template::Set(
-    Local<Name> name, Local<Data> value, PropertyAttribute attributes) {
+Object* GetTemplateProperties(Template* const templ) {
   ExternalData* externalData = nullptr;
-  if (!ExternalData::TryGet(this, &externalData)) {
+  if (!ExternalData::TryGet(templ, &externalData)) {
     // This should never happen
     CHAKRA_ASSERT(false);
-    return;
+    return nullptr;
   }
 
   TemplateData *templateData = static_cast<TemplateData*>(externalData);
-  Object* properties = templateData->EnsureProperties();
+  return templateData->EnsureProperties();
+}
+
+void Template::Set(
+    Local<Name> name, Local<Data> value, PropertyAttribute attributes) {
+  Object* properties = GetTemplateProperties(this);
   if (properties != nullptr) {
     properties->ForceSet(name, value.As<Value>(), attributes);
   }
 }
 
+void Template::SetAccessorProperty(
+    Local<Name> name,
+    Local<FunctionTemplate> getter,
+    Local<FunctionTemplate> setter,
+    PropertyAttribute attribute,
+    AccessControl access_control) {
+  Object* properties = GetTemplateProperties(this);
+  if (properties != nullptr) {
+    properties->SetAccessorProperty(
+        name,
+        getter->GetFunction(),
+        setter->GetFunction(),
+        attribute,
+        access_control);
+  }
+}
+
 }  // namespace v8