chakrashim: added missing Function methods

nodejs · Sep 25, 2017 · b871421 · b871421
1 parent 3a11337
commit b871421
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -1810,11 +1810,13 @@ class V8_EXPORT Function : public Object {
   Local<Value> GetName() const;
 
   Local<Value> GetInferredName() const;
+  Local<Value> GetDebugName() const;
 
   int GetScriptLineNumber() const;
   int GetScriptColumnNumber() const;
 
   int ScriptId() const;
+  Local<Value> GetBoundFunction() const;
 
   static Function *Cast(Value *obj);
   static const int kLineOffsetNotFound;
@@ -2396,7 +2398,10 @@ class V8_EXPORT MicrotasksScope {
 enum GCType {
   kGCTypeScavenge = 1 << 0,
   kGCTypeMarkSweepCompact = 1 << 1,
-  kGCTypeAll = kGCTypeScavenge | kGCTypeMarkSweepCompact
+  kGCTypeIncrementalMarking = 1 << 2,
+  kGCTypeProcessWeakCallbacks = 1 << 3,
+  kGCTypeAll = kGCTypeScavenge | kGCTypeMarkSweepCompact |
+               kGCTypeIncrementalMarking | kGCTypeProcessWeakCallbacks
 };
 
 enum GCCallbackFlags {

diff --git a/deps/chakrashim/src/v8function.cc b/deps/chakrashim/src/v8function.cc
@@ -133,6 +133,12 @@ Local<Value> Function::GetInferredName() const {
   return Local<Value>();
 }
 
+Local<Value> Function::GetDebugName() const {
+  // CHAKRA-TODO: Figure out what to do here
+  CHAKRA_ASSERT(false);
+  return Local<Value>();
+}
+
 const int Function::kLineOffsetNotFound = -1;
 
 int Function::GetScriptLineNumber() const {
@@ -153,6 +159,11 @@ int Function::ScriptId() const {
   return 0;
 }
 
+Local<Value> Function::GetBoundFunction() const {
+  CHAKRA_ASSERT(false);
+  return Local<Value>();
+}
+
 Function *Function::Cast(Value *obj) {
   CHAKRA_ASSERT(obj->IsFunction());
   return static_cast<Function*>(obj);