test: disable test case for node-chakracore and fix a couple lint issues

nodejs · Jan 11, 2018 · b2a4b8a · b2a4b8a
1 parent 53cfc2c
commit b2a4b8a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/node_api_jsrt.cc b/src/node_api_jsrt.cc
@@ -907,11 +907,11 @@ napi_status napi_define_properties(napi_env env,
                                    const napi_property_descriptor* properties) {
   JsPropertyIdRef configurableProperty;
   CHECK_JSRT(JsCreatePropertyId(STR_AND_LENGTH("configurable"),
-    &configurableProperty));
+                                &configurableProperty));
 
   JsPropertyIdRef enumerableProperty;
   CHECK_JSRT(JsCreatePropertyId(STR_AND_LENGTH("enumerable"),
-    &enumerableProperty));
+                                &enumerableProperty));
 
   for (size_t i = 0; i < property_count; i++) {
     const napi_property_descriptor* p = properties + i;
@@ -967,7 +967,7 @@ napi_status napi_define_properties(napi_env env,
 
       JsPropertyIdRef writableProperty;
       CHECK_JSRT(JsCreatePropertyId(STR_AND_LENGTH("writable"),
-        &writableProperty));
+                                    &writableProperty));
       JsValueRef writable;
       CHECK_JSRT(JsBoolToBoolean((p->attributes & napi_writable), &writable));
       CHECK_JSRT(JsSetProperty(descriptor, writableProperty, writable, true));
@@ -2065,7 +2065,7 @@ napi_status napi_new_instance(napi_env env,
 napi_status napi_make_external(napi_env env, napi_value v, napi_value* result) {
   CHECK_ARG(result);
   JsValueRef externalObj;
-  CHECK_JSRT(JsCreateExternalObject(NULL, NULL, &externalObj));
+  CHECK_JSRT(JsCreateExternalObject(nullptr, nullptr, &externalObj));
   CHECK_JSRT(JsSetPrototype(externalObj, reinterpret_cast<JsValueRef>(v)));
   *result = reinterpret_cast<napi_value>(externalObj);
   return napi_ok;
@@ -2742,8 +2742,8 @@ class Work: public node::AsyncResource {
       JsValueRef exception;
       JsPropertyIdRef exProp;
 
-      if (JsCreatePropertyId(STR_AND_LENGTH("exception"), &exProp)
-          != JsNoError) {
+      if (JsCreatePropertyId(STR_AND_LENGTH("exception"),
+                             &exProp) != JsNoError) {
         Fatal();
         return;
       }

diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -103,6 +103,10 @@ test-vm-harmony-symbols : SKIP
 test-vm-indexed-properties : SKIP
 test-vm-proxies : SKIP
 
+# This test depends on V8 error API for stack traces which is not implemented
+# in Node-ChakraCore
+test-common-must-not-call : SKIP
+
 [$jsEngine==chakracore && $arch==x64]
 # These tests are failing for Node-Chakracore and should eventually be fixed
 test-buffer-includes : SKIP