chakrashim: shim updated apis

nodejs · Jan 9, 2018 · a2e28d7 · a2e28d7
1 parent ad7c2e2
commit a2e28d7
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/deps/chakrashim/include/v8.h b/deps/chakrashim/include/v8.h
@@ -2639,11 +2639,24 @@ class V8_EXPORT Isolate {
     Isolate* isolate, GCType type, GCCallbackFlags flags);
   typedef void(*GCCallback)(Isolate* isolate, GCType type,
                             GCCallbackFlags flags);
+  typedef void (*GCCallbackWithData)(Isolate* isolate, GCType type,
+                            GCCallbackFlags flags, void* data);
+
+  void AddGCPrologueCallback(
+    GCCallbackWithData callback, void* data = nullptr,
+    GCType gc_type_filter = kGCTypeAll);
   void AddGCPrologueCallback(
     GCCallback callback, GCType gc_type_filter = kGCTypeAll);
+  void RemoveGCPrologueCallback(
+    GCCallbackWithData callback, void* data = nullptr);
   void RemoveGCPrologueCallback(GCCallback callback);
+  void AddGCEpilogueCallback(
+    GCCallbackWithData callback, void* data = nullptr,
+    GCType gc_type_filter = kGCTypeAll);
   void AddGCEpilogueCallback(
     GCCallback callback, GCType gc_type_filter = kGCTypeAll);
+  void RemoveGCEpilogueCallback(
+    GCCallbackWithData callback, void* data = nullptr);
   void RemoveGCEpilogueCallback(GCCallback callback);
 
   void CancelTerminateExecution();

diff --git a/deps/chakrashim/src/v8isolate.cc b/deps/chakrashim/src/v8isolate.cc
@@ -172,17 +172,33 @@ CpuProfiler* Isolate::GetCpuProfiler() {
   return &dummyCpuProfiler;
 }
 
+void Isolate::AddGCPrologueCallback(
+  GCCallbackWithData callback, void* data, GCType gc_type_filter) {
+}
+
 void Isolate::AddGCPrologueCallback(
   GCCallback callback, GCType gc_type_filter) {
 }
 
+void Isolate::RemoveGCPrologueCallback(
+  GCCallbackWithData callback, void* data) {
+}
+
 void Isolate::RemoveGCPrologueCallback(GCCallback callback) {
 }
 
+void Isolate::AddGCEpilogueCallback(
+  GCCallbackWithData callback, void* data, GCType gc_type_filter) {
+}
+
 void Isolate::AddGCEpilogueCallback(
   GCCallback callback, GCType gc_type_filter) {
 }
 
+void Isolate::RemoveGCEpilogueCallback(
+  GCCallbackWithData callback, void* data) {
+}
+
 void Isolate::RemoveGCEpilogueCallback(GCCallback callback) {
 }