test,build: implement no-ops for Promise::Resolver methods, mark test…

…s as flaky
nodejs · Sep 27, 2017 · 743f634 · 743f634
1 parent 08a2c07
commit 743f634
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/deps/chakrashim/src/v8resolver.cc b/deps/chakrashim/src/v8resolver.cc
@@ -24,11 +24,19 @@
 namespace v8 {
   using Resolver = Promise::Resolver;
   // CHAKRA-TODO: Unimplemented completely
-  MaybeLocal<Resolver> Resolver::New(
-    Local<Context> context) {
+  MaybeLocal<Resolver> Resolver::New(Local<Context> context) {
     return Local<Resolver>();
   }
 
+  Local<Resolver> Resolver::New(Isolate* isolate) {
+    return New(isolate->GetCurrentContext()).ToLocalChecked();
+  }
+
+  Local<Promise> Resolver::GetPromise() {
+    CHAKRA_ASSERT(false);
+    return Local<Promise>();
+  }
+
   Resolver* Resolver::Cast(Value* obj) {
     return static_cast<Resolver*>(obj);
   }
@@ -37,6 +45,11 @@ namespace v8 {
     return Just(false);
   }
 
+  void Resolver::Resolve(Local<Value> value) {
+    Local<Context> context;
+    Resolve(context, value);
+  }
+
   Maybe<bool> Resolver::Reject(Local<Context> context, Local<Value> value) {
     return Just(false);
   }

diff --git a/test/addons/addon.status b/test/addons/addon.status
@@ -21,3 +21,5 @@ prefix addons
 [$jsEngine==chakracore]
 async-hooks-promise/test : PASS,FLAKY
 new-target/test : PASS,FLAKY
+callback-scope/test : PASS,FLAKY
+callback-scope/test-resolve-async : PASS,FLAKY