lib,src: enable TTD record with env variable

* Added support for the `DO_TTD_RECORD` environment variable to start recording * Added code to write the environment variable if `--record` is passed to the node command line for child processes to consume * Added the pid to the trace filename to prevent collisions Fixes #273 PR-URL: #285 Reviewed-By: Hitesh Kanwathirtha <[email protected]>
nodejs · Jun 13, 2017 · 5868614 · 5868614
1 parent b0681ba
commit 5868614
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/trace_mgr.js b/lib/trace_mgr.js
@@ -157,6 +157,9 @@ function createTraceLogTarget(tracename) {
   var traceRootDir = emitOptions.localTraceDirectory ||
     path.dirname(process.mainModule.filename);
 
+  // Add the PID to the trace name
+  tracename = `${tracename}_pid${process.pid}`;
+
   var resolvedTracePath =
     path.resolve(traceRootDir, '_diagnosticTraces', tracename);
 

diff --git a/src/node.cc b/src/node.cc
@@ -4981,6 +4981,15 @@ int Start(int argc, char** argv) {
 #if ENABLE_TTD_NODE
   bool chk_debug_enabled = debug_options.inspector_enabled();
 
+  std::string envDoRecordVar;
+  bool envDoRecord = SafeGetenv("DO_TTD_RECORD", &envDoRecordVar) &&
+      envDoRecordVar[0] == '1';
+
+  if (!s_doTTRecord && !s_doTTReplay) {
+    // Apply the value from the environment variable
+    s_doTTRecord = envDoRecord;
+  }
+
   TTDFlagWarning_Cond(!s_doTTRecord || !s_doTTReplay,
       "Cannot enable record & replay at same time.\n");
 
@@ -5010,6 +5019,11 @@ int Start(int argc, char** argv) {
       TTDFlagWarning_Cond(s_ttoptReplayUri != nullptr,
           "Must set replay source info when replaying.\n");
   }
+
+  if (s_doTTRecord) {
+    // Apply the environment variable to be inherited by child processes.
+    putenv("DO_TTD_RECORD=1");
+  }
 #endif