lib: mark Buffer/SlowBuffer not supporting @@species

Buffer/SlowBuffer not supporting @@species constructor. Mark them as such to avoid failure with TypedArray @@species spec. Reviewed-by: @kunalspathak
nodejs · Sep 21, 2015 · 3a55f98 · 3a55f98
1 parent 91b675a
commit 3a55f98
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -39,6 +39,15 @@ function alignPool() {
   }
 }
 
+// Mark a constructor not supporting @@species
+function markNoSpeciesConstructor(constructor) {
+  if (Symbol.species) {
+    Object.defineProperty(constructor, Symbol.species, {
+      get: function() { return undefined; },
+      configurable: true,
+    });
+  }
+}
 
 function Buffer(arg) {
   // Common case.
@@ -60,6 +69,7 @@ function Buffer(arg) {
 
 Buffer.prototype.__proto__ = Uint8Array.prototype;
 Buffer.__proto__ = Uint8Array;
+markNoSpeciesConstructor(Buffer);
 
 
 function SlowBuffer(length) {
@@ -74,6 +84,7 @@ function SlowBuffer(length) {
 
 SlowBuffer.prototype.__proto__ = Buffer.prototype;
 SlowBuffer.__proto__ = Buffer;
+markNoSpeciesConstructor(SlowBuffer);
 
 
 function allocate(size) {