test,chakrashim: Updated v8-version

test: more chakrashim test fixes PR-URL: #186 Reviewed-By: Hitesh Kanwathirtha <[email protected]>
nodejs · Mar 15, 2017 · 374a1d8 · 374a1d8
1 parent 4ef4e84
commit 374a1d8
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 5 deletions.
diff --git a/deps/chakrashim/include/v8-version.h b/deps/chakrashim/include/v8-version.h
@@ -34,7 +34,7 @@
 #define V8_MAJOR_VERSION 5
 #define V8_MINOR_VERSION 6
 #define V8_BUILD_NUMBER 326
-#define V8_PATCH_LEVEL 55
+#define V8_PATCH_LEVEL 56
 
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)

diff --git a/test/inspector/inspector.status b/test/inspector/inspector.status
@@ -11,4 +11,5 @@ prefix inspector
 [$jsEngine==chakracore]
 test-inspector : SKIP
 test-inspector-stops-no-file : SKIP
-test-not-blocked-on-idle : SKIP
+test-not-blocked-on-idle : SKIP
+test-inspector-ip-detection : SKIP
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -77,7 +77,7 @@ test-vm-timeout : SKIP
 test-whatwg-url-origin-for : SKIP
 test-assert-checktag : SKIP
 test-process-env-symbols : SKIP
-test-util-format : SKIP
+test-module-loading-globalpaths : SKIP
 
 [$jsEngine==chakracore && $arch==x64]
 test-buffer-includes : SKIP

diff --git a/test/parallel/test-util-format.js b/test/parallel/test-util-format.js
@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const util = require('util');
 const symbol = Symbol('foo');
@@ -83,7 +83,18 @@ assert.strictEqual(util.format('o: %j, a: %j'), 'o: %j, a: %j');
 {
   const o = {};
   o.o = o;
-  assert.strictEqual(util.format('%j', o), '[Circular]');
+  if (!common.isChakraEngine) {
+    assert.strictEqual(util.format('%j', o), '[Circular]');
+  } else {
+    assert.throws(() => { util.format('%j', o); }, function(err) {
+      if (err instanceof TypeError &&
+          err.message === 'Circular reference in value argument not ' +
+                          'supported') {
+        return true;
+      }
+      return false;
+    });
+  }
 }
 
 {