Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
chakrashim: some minor shim cleanups
Browse files Browse the repository at this point in the history
* Deprecate HandleScope::close.
* Deprecate EXPORT (use V8_EXPORT).
* Cache hasOwnProperty and a few more other propertyIds.
* Change StackTrace/StackFrame to be more v8-like.
* Add internal methods Number::From/Integer::From etc. for perf.
* Fix some remaining JsCallFunction nullptr arg issue.

Reviewed-by: @kunalspathak
  • Loading branch information
Jianchun Xu committed Aug 21, 2015
1 parent 72f0702 commit 33d79fa
Show file tree
Hide file tree
Showing 23 changed files with 219 additions and 207 deletions.
2 changes: 1 addition & 1 deletion deps/chakrashim/include/v8-debug.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
namespace v8 {

// NOT IMPLEMENTED
class EXPORT Debug {
class V8_EXPORT Debug {
public:
class ClientData {
};
Expand Down
6 changes: 3 additions & 3 deletions deps/chakrashim/include/v8-profiler.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
namespace v8 {

// NOT IMPLEMENTED
class EXPORT CpuProfiler {
class V8_EXPORT CpuProfiler {
public:
// void SetSamplingInterval(int us);
// void StartProfiling(Handle<String> title, bool record_samples = false);
Expand All @@ -40,7 +40,7 @@ class EXPORT CpuProfiler {
};

// NOT IMPLEMENTED
class EXPORT HeapProfiler {
class V8_EXPORT HeapProfiler {
public:
typedef RetainedObjectInfo *(*WrapperInfoCallback)(
uint16_t class_id, Handle<Value> wrapper);
Expand All @@ -50,7 +50,7 @@ class EXPORT HeapProfiler {
};

// NOT IMPLEMENTED
class EXPORT RetainedObjectInfo {
class V8_EXPORT RetainedObjectInfo {
public:
virtual void Dispose() = 0;
virtual bool IsEquivalent(RetainedObjectInfo *other) = 0;
Expand Down
Loading

0 comments on commit 33d79fa

Please sign in to comment.