Updates for N-API async changes #10
Conversation
napi-inl.h
Outdated
| @@ -1316,15 +1322,15 @@ inline T Reference<T>::Value() const { | |||
|
|
|||
| template <typename T> | |||
| inline int Reference<T>::Ref() { | |||
There was a problem hiding this comment.
Either the type is wrong or result needs a typecast before returning.
There was a problem hiding this comment.
Fixed here and a few other places.
napi-inl.h
Outdated
| @@ -1316,15 +1322,15 @@ inline T Reference<T>::Value() const { | |||
|
|
|||
| template <typename T> | |||
| inline int Reference<T>::Ref() { | |||
| int result; | |||
| uint32_t result; | |||
| napi_status status = napi_reference_ref(_env, _ref, &result); | |||
| if (status != napi_ok) throw Error::New(_env); | |||
| return result; | |||
| } | |||
|
|
|||
| template <typename T> | |||
| inline int Reference<T>::Unref() { | |||
There was a problem hiding this comment.
Either the type is wrong or result needs a typecast before returning.
|
@boingoing What is the plan for getting the async APIs into node? Anyway, I don't see any point in holding this PR until those changes land, because the current code in this repo references the old N-API async functions that never landed in node. So updating this repo won't make things any worse. |
Prepping the PR for these changes as well as the one which changes Agreed, no reason to hold on the changes in this PR here. |
Updates for pending changes in async APIs at nodejs/abi-stable-node#204, along with other recent changes.
napi_worktonapi_async_workenvparameter and return anapi_statusnapi_cancel_async_work()APIErrorobject for async work errors, rather than just an error message.napi_status