Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Removed references to Node.js lower than 10.x. #709

Merged
merged 7 commits into from
Apr 29, 2020
Merged

doc: Removed references to Node.js lower than 10.x. #709

merged 7 commits into from
Apr 29, 2020

Conversation

NickNaso
Copy link
Member

Find places were we document which versions of Node.js are support and remove all lower than
10.x.
Refs: #689

@NickNaso NickNaso added the doc label Apr 27, 2020
@NickNaso NickNaso changed the title [doc] Removed references to Node.js lower than 10.x. doc: Removed references to Node.js lower than 10.x. Apr 27, 2020
@mhdawson mhdawson mentioned this pull request Apr 27, 2020
8 tasks
@mhdawson
Copy link
Member

What you had looked good but I think we need to say somewhere specifically what is/is not supported. I pushed a commit which contains my suggestion.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
Added changes suggested in the review.

Co-Authored-By: Athan <[email protected]>
@mhdawson
Copy link
Member

@NickNaso are you ok with the additions I made? If so I'll go ahead and land it.

@NickNaso
Copy link
Member Author

@NickNaso are you ok with the additions I made? If so I'll go ahead and land it.

@mhdawson Yes, I'm ok. Please land it.

@mhdawson mhdawson merged commit 187318e into nodejs:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants