fix: missing napi_delete_reference on ObjectWrap ref #1607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://nodejs.org/api/n-api.html#napi_wrap, the
napi_reference
returned fromnapi_wrap
should be deleted withnapi_delete_reference
. In node-addon-api, for anObjectWrap
, this is done with~Reference
destructor when the_ref
is notnullptr
.To prevent
~ObjectWrap
from creating a handle during finalization, add a new flag to guard on it, instead of nullify_ref
.Submitted nodejs/node#55620 to allow
napi_delete_reference
been immediately invoked in annode_api_basic_finalizer
.Fixes #1602