Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a new Buffer::NewOrCopy method #1257

Closed
Julusian opened this issue Dec 29, 2022 · 3 comments
Closed

Provide a new Buffer::NewOrCopy method #1257

Julusian opened this issue Dec 29, 2022 · 3 comments

Comments

@Julusian
Copy link

Background:

After nodejs/node#45181 it is possible for Buffer::new to fail with napi_no_external_buffers_allowed. A helper method Buffer::NewOrCopy which would try to do a Buffer::new and fallback to doing a Buffer::copy would be helpful and encourage users to code in a way which provides compatibility for both electron and nodejs, without them having to implement the method themselves.

The npm package sharp has implemented this themselves already lovell/sharp@584807b#diff-53a01d31aa585021f8f316c6613dadef86bf1f9ac2070d52daa68adbefbb6ef4.

@mhdawson
Copy link
Member

We discussed in the team meeting today, and we agreed it would make sense to add. @legendecas volunteered to put together a PR.

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Apr 14, 2023
@legendecas
Copy link
Member

Landed in #1273.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants