You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to the following line: T *new_data = new T[count];
in the AsyncProgress(Queue)Worker class T (your progress class) is required to have a default constructor.
I have prepared a patch which makes use of C++17 (std::aligned_alloc and std::uninitialized_copy) features and removes the necessity of the progress struct having a default constructor.
Should I wrap the patch in a feature guard (__cplusplus macro check) and file a merge request?
The text was updated successfully, but these errors were encountered:
If it is not much work for you, do file a PR. It would at least make it easier to evaluate its impact. The only possible problem I can imagine right now is a compiler which is marketed as supporting a particular C++ standard, but actually does not do so fully.
Hi,
Due to the following line:
T *new_data = new T[count];
in the AsyncProgress(Queue)Worker class
T
(your progress class) is required to have a default constructor.I have prepared a patch which makes use of C++17 (
std::aligned_alloc
andstd::uninitialized_copy
) features and removes the necessity of the progress struct having a default constructor.Should I wrap the patch in a feature guard (
__cplusplus
macro check) and file a merge request?The text was updated successfully, but these errors were encountered: