Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give merge permissions to @ShogunPanda #167

Closed
ShogunPanda opened this issue Jul 25, 2022 · 5 comments
Closed

Give merge permissions to @ShogunPanda #167

ShogunPanda opened this issue Jul 25, 2022 · 5 comments

Comments

@ShogunPanda
Copy link
Contributor

As Node.js member involved in the HTTP stack, I'd like to have merge permissions here on llhttp not to be blocked when working on the parser.

@mcollina
Copy link
Member

cc @indutny @nodejs/tsc

@aduh95
Copy link

aduh95 commented Jul 25, 2022

Currently, the permissions on this repo are set as such:

  • @indutny has write access.
  • @nodejs/tsc has read access.

So only one member has write access, that doesn't seem right – of course, the TSC being admin on the org also have full access, but it would be worth updating anyway, but imo it would be better not to have to use our admin privileges unless strictly necessary.
We should probably create a @nodejs/llhttp team and give it "Maintain" permission on this repo.

@mcollina
Copy link
Member

I agree

@aduh95
Copy link

aduh95 commented Jul 25, 2022

@ShogunPanda I think you can request to join the not-yet-created team on nodejs/admin#705, and if there's no objections after 72 hours, it will be automatically accepted.

@aduh95
Copy link

aduh95 commented Aug 3, 2022

Fixed by nodejs/admin#705.

@aduh95 aduh95 closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants