-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we extend jenkins-alerts to release machines? #3414
Should we extend jenkins-alerts to release machines? #3414
Comments
+1. FWIW our orka macOS release machines are currently all offline #3416 |
I can create a PR for it, but I will need help to generate a valid token and also to add it in the repository secrets. |
Hmm actually that's a good point. Do we remember which Jenkins user we're using? If it's one of the build automation GH users it won't have access to the release Cl. |
Currently, I think it is using a personal token from my account on |
hmm. FWIW @UlisesGascon I sent an email to the other members of @nodejs/build-infra today suggesting we upgrade your level of access. Although maybe we ought to be setting up the automation with one of our Build WG-owned automation accounts. |
Thanks! :)
Yes, 100 we should replace the current token for a one generated by a Build WG-owned automation accounts and keep the token in the secrets repo as well. I created a PR nodejs/jenkins-alerts#262 for the changes. |
@richardlau should I use @nodejs-ci account to generate the tokens? |
@UlisesGascon I can't remember if that account has access to Jenkins (either one). I think it's used by our Jenkins jobs to check code out of GitHub. |
@UlisesGascon @node-forward-build might be a better account to use, depending on whether we can create API tokens with less access than the user has. |
If Jenkins doesn't support restricted API tokens, we may have to use another account (such as @nodejs-ci) and get that account added to both Jenkins with minimum read-only permissions. |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
I was thinking that currently we are only tracking the machines under
ci.nodejs.org
, but this is limited to the test machines. Should we extended it to the release machines?The text was updated successfully, but these errors were encountered: