Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Enormous footer on API site #189

Closed
bnb opened this issue Feb 13, 2015 · 6 comments
Closed

Enormous footer on API site #189

bnb opened this issue Feb 13, 2015 · 6 comments

Comments

@bnb
Copy link

bnb commented Feb 13, 2015

I just went poking around, and I noticed this enormous footer on the docs site:

bigfooter

That's Firefox, but it's the same on Chrome. Is there a reason for this?

@Fishrock123
Copy link
Contributor

Docs styles and content are still in the main repo. :)

Looks like it was an oversight when @chrisdickinson was re-styling the docs for io.js, I think joyent has stuff down their in the node docs.

The relavent lines are https://github.com/iojs/io.js/blob/v1.x/doc/api_assets/style.css#L394-L399 -- I'd gladly take a PR to make it like only 20px or something.

@bnb
Copy link
Author

bnb commented Feb 13, 2015

+1 for a PR to fix. Will this WG be inheriting the docs at some point? I was also going to raise an issue about how we'd need to be able to style them consistently with a redesign, but figured that would be automatic since they were part of this WG's repo--turns out I was wrong.

@Fishrock123
Copy link
Contributor

Yeah. See nodejs/node#727

@chrisdickinson
Copy link

Ah, the footer was a bit of a rush job. Eventually site navigation was to go there.

@bnb
Copy link
Author

bnb commented Feb 13, 2015

@chrisdickinson Ah, okay.

@snostorm
Copy link
Contributor

Seems to have been merged upstream. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants