Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

build: Upload Glossary on merge to master #240

Merged
merged 1 commit into from
Mar 15, 2020
Merged

build: Upload Glossary on merge to master #240

merged 1 commit into from
Mar 15, 2020

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Mar 15, 2020 •
edited
Loading

Fixes #231

Not sure about if there is further work to wire in the upload with the CROWDIN_KEY

Someone will also need to set the CROWDIN_KEY value in the repo's secrets

@zeke
Copy link
Contributor

zeke commented Mar 15, 2020

Someone will also need to set the CROWDIN_KEY value in the repo's secrets

✅ Done!

Screen Shot 2020-03-14 at 10 20 05 PM

zeke
zeke approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will leave it open for others to review.

cc @alexandrtovmach @maddhruv @obensource @RichardLitt

maddhruv
maddhruv approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@maddhruv maddhruv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets ship it

@maddhruv maddhruv merged commit 3057a5a into nodejs:master Mar 15, 2020
@nschonni nschonni deleted the glossary-action branch March 15, 2020 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maddhruv maddhruv maddhruv approved these changes

@zeke zeke zeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload new glossary terms to Crowdin
3 participants
@nschonni @zeke @maddhruv