Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add 2016-10-05 diag WG meeting notes #68

Merged
merged 1 commit into from
Oct 31, 2016
Merged

doc: add 2016-10-05 diag WG meeting notes #68

merged 1 commit into from
Oct 31, 2016

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Oct 11, 2016

Adds meeting notes, closes #64.

/cc @nodejs/diagnostics

AndreasMadsen

This comment was marked as off-topic.

Sign in to view

@joshgav joshgav mentioned this pull request Oct 19, 2016
Closed
4 tasks
joshgav added a commit to joshgav/diagnostics that referenced this pull request Oct 27, 2016
@joshgav
doc: add 2016-10-05 WG meeting notes
33a74a3 
PR-URL: nodejs#68
Reviewed-By: Andreas Madsen <[email protected]>
Reviewed-By: <tbd>
@joshgav
Copy link
Contributor Author

joshgav commented Oct 27, 2016

Updated. @AndreasMadsen PTAL.

@nodejs/diagnostics - can I get another LGTM before merging? Thanks!

@joshgav joshgav mentioned this pull request Oct 27, 2016
Closed
@AndreasMadsen
Copy link
Member

AndreasMadsen commented Oct 27, 2016 •
edited
Loading

trevnorris is working on a JS wrapper module for async_hooks to make it more useable for end users.

Its fine. But just to clarify: async_hooks is the name of the wrapper for async_wrap. It has another name because async_wrap is the name of of the C++ class that async_hooks (the module API) uses.

edit: though I will say that having the headline "Next steps:" is rather confusing, as it is actually what is happening now. In the previous meeting it made sense, but since then we have moved on.

@joshgav
Copy link
Contributor Author

joshgav commented Oct 31, 2016

@AndreasMadsen

edit: though I will say that having the headline "Next steps:" is rather confusing, as it is actually what is happening now. In the previous meeting it made sense, but since then we have moved on.

This part of the notes is actually meant to recap the previous meeting, so I think it's okay that it reflects an old state. More important will be to document this all properly at some point.

@joshgav joshgav merged commit 8937270 into nodejs:master Oct 31, 2016
@joshgav
Copy link
Contributor Author

joshgav commented Oct 31, 2016

landed in 8937270

@joshgav joshgav deleted the oct-meeting branch November 1, 2016 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasMadsen AndreasMadsen AndreasMadsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diag WG Meeting - 2016-10-05
2 participants
@joshgav @AndreasMadsen