-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CentOS 5 #898
Comments
We are still building 4 and 6 binaries with CentOS 5 and we can't change that so we should continue to support it there, it's unlikely to cause too much trouble with the small incremental changes going in to 4 and 6, especially when 6 heads into Maintenance. CentOS6 is used for binaries of 8+. |
@rvagg If I'm understanding you correctly, we can't remove CentOS 5 machines completely until Node.js 6.x is unsupported which won't be until April 2019. Is that right? Yikes! But, yeah, I get it. |
yerp, that's correct, kind of tied ourselves to a bit of a donkey with that one but it's a bit hard to change now |
We should definitely do this. |
Seems like if push comes to shove we can at least provision a new CentOS5 machine on AWS (either a comunity AMI or install our own) |
Another CentOS 5-only flaky (and thus a probable argument for removing CentOS 5 from CI): nodejs/node#14982 |
Okay, so I've replaced this code in https://ci.nodejs.org/job/node-test-commit-linux : # clang is only supported in Node versions 7 and lower
MAJOR_VERSION=`cat src/node_version.h |grep "#define NODE_MAJOR_VERSION" | awk '{ print $3}'`
RUN_TESTS="RUN"
echo $SMARTOS_VERSION
if [[ "$nodes" =~ ubuntu1204 && ${MAJOR_VERSION} -gt 7 ]]; then
RUN_TESTS=DONT_RUN
SKIP_MESSAGE="ubuntu1204 is not supported for version 8 and above, skipping"
elif [[ "$nodes" = fedora22 && ${MAJOR_VERSION} -gt 7 ]]; then
RUN_TESTS=DONT_RUN
SKIP_MESSAGE="fedora22 is not supported for version 8 and above, skipping"
fi # clang is only supported in Node versions 7 and lower
MAJOR_VERSION=`cat src/node_version.h |grep "#define NODE_MAJOR_VERSION" | awk '{ print $3}'`
RUN_TESTS="RUN"
echo $SMARTOS_VERSION
if [[ ${MAJOR_VERSION} -gt 7 && "$nodes" =~ 'ubuntu1204|fedora22|centos5' ]]; then
RUN_TESTS=DONT_RUN
SKIP_MESSAGE="$nodes is not supported for version 8 and above, skipping"
fi Please let me know if this is wrong! |
"if" sample:
"else" sample:
SGTM |
Hi, @nodejs/build friends.
CentOS 5 is an EOL operating system. See https://lists.centos.org/pipermail/centos-announce/2017-April/022350.html
It has caused problems in CI at least once, resulting in @mcollina needing to make a test more complicated than it was. See test: defer abort with setTimeout node#15520.
IIUC, it is not a supported operating system. See build: update minimum kernel version to 3.10.0 node#14795.
Given all of that, at what point do we remove it from Ci? Is this sort of thing documented anywhere? Is the Build WG the right collection of people to decide?
(Apologies in advance if this has all ben discussed already, which I think it has.)
The text was updated successfully, but these errors were encountered: