Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test npm on the CI #234

Closed
Fishrock123 opened this issue Nov 2, 2015 · 2 comments
Closed

Test npm on the CI #234

Fishrock123 opened this issue Nov 2, 2015 · 2 comments
Labels
ci-public

Comments

@Fishrock123
Copy link
Contributor

As of around nodejs/node#3599, make test-npm works even without node or npm in the PATH.

npm's legacy tests still require internet, but as a first step, I suggest we disable those and run the tests that don't require internet. (The tap tests I believe.)

The windows tests are apparently in pretty bad shape last I heard, so I recommend we start with OS X and then Linux.

cc @othiym23, @zkat, @iarna, @jasnell?
@Fishrock123 Fishrock123 mentioned this issue Nov 6, 2015
Closed
@maclover7
Copy link
Contributor

Should this be combined with #317 or closed?

@maclover7 maclover7 mentioned this issue Oct 15, 2017
Closed
@gibfahn
Copy link
Member

gibfahn commented Oct 16, 2017

Yep, closing as a duplicate of #317 as that one has more info in it.

@gibfahn gibfahn closed this as completed Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-public
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fishrock123 @maclover7 @gibfahn