-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-test-commit-custom-suites failing to fetch git repo #1431
Comments
Could be related to #1432, I don't see an env.properties in the node-test-commit hand-off for it. @gibfahn this one is yours isn't it? Perhaps this work would be better to shoehorn into linux-containered where we do custom variations already so this would be just a matter of adding a new block in the config there and adding a new label for all of the available "sharedlibs" containers. Having multiple ways to spawn custom builds & test runs might be creating a rod for our own backs by layering complexity. I'm happy to do that work unless you have good reason for this to be a separate configuration or want to migrate the work in linux-containered to this new style. |
I was the one who added the worker tests to node-test-commit (tracking issue was #1318) -- just updated the job config to pass
Not sure if it fits easily into the containers work or not -- the idea with |
@maclover7 we have generic images and "sharedlibs" images in the pool, but even the "sharedlibs" ones are pretty vanilla because they just put the shared custom libaries in /opt/ (iirc) so they are suitable for this kind of thing. These custom test suites are actually pretty similar to the build variations we do like |
https://ci.nodejs.org/job/node-test-commit-custom-suites/517/console
The text was updated successfully, but these errors were encountered: